Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9048)

Unified Diff: chrome/browser/web_resource/notification_promo.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/web_resource/notification_promo.cc
diff --git a/chrome/browser/web_resource/notification_promo.cc b/chrome/browser/web_resource/notification_promo.cc
index c4f03da43d7b34608ca66796de45548405734db5..d772d13ab765238700a6a5788d79452138661294 100644
--- a/chrome/browser/web_resource/notification_promo.cc
+++ b/chrome/browser/web_resource/notification_promo.cc
@@ -17,8 +17,8 @@
#include "base/values.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/prefs/pref_registry_simple.h"
+#include "chrome/browser/prefs/pref_registry_syncable.h"
#include "chrome/browser/prefs/pref_service.h"
-#include "chrome/browser/prefs/pref_service_syncable.h"
#include "chrome/browser/web_resource/promo_resource_service.h"
#include "chrome/common/chrome_version_info.h"
#include "chrome/common/pref_names.h"
@@ -315,11 +315,13 @@ void NotificationPromo::RegisterPrefs(PrefRegistrySimple* registry) {
}
// static
-void NotificationPromo::RegisterUserPrefs(PrefServiceSyncable* prefs) {
+void NotificationPromo::RegisterUserPrefs(PrefService* prefs,
+ PrefRegistrySyncable* registry) {
// TODO(dbeam): Remove in M28 when we're reasonably sure all prefs are gone.
// http://crbug.com/168887
- prefs->RegisterDictionaryPref(kPrefPromoObject,
- PrefServiceSyncable::UNSYNCABLE_PREF);
+ // TODO(joi): Remove PrefService parameter; move this to migration code.
+ registry->RegisterDictionaryPref(kPrefPromoObject,
+ PrefRegistrySyncable::UNSYNCABLE_PREF);
prefs->ClearPref(kPrefPromoObject);
}
« no previous file with comments | « chrome/browser/web_resource/notification_promo.h ('k') | chrome/browser/web_resource/promo_resource_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698