Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4705)

Unified Diff: chrome/browser/sync/sync_prefs.h

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service_preference_unittest.cc ('k') | chrome/browser/sync/sync_prefs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_prefs.h
diff --git a/chrome/browser/sync/sync_prefs.h b/chrome/browser/sync/sync_prefs.h
index 8f97b6df79085ee484e52767aafd5d3481dac004..b0b2fb0f18ce82bfb1325088b678cd0a9bb93cc5 100644
--- a/chrome/browser/sync/sync_prefs.h
+++ b/chrome/browser/sync/sync_prefs.h
@@ -15,7 +15,8 @@
#include "sync/internal_api/public/base/model_type.h"
#include "sync/notifier/invalidation_state_tracker.h"
-class PrefServiceSyncable;
+class PrefRegistrySyncable;
+class PrefService;
class ProfileIOData;
namespace browser_sync {
@@ -49,11 +50,12 @@ class SyncPrefs : NON_EXPORTED_BASE(public base::NonThreadSafe),
// |pref_service| may be NULL (for unit tests), but in that case no
// setter methods should be called. Does not take ownership of
// |pref_service|.
- explicit SyncPrefs(PrefServiceSyncable* pref_service);
+ explicit SyncPrefs(PrefService* pref_service);
virtual ~SyncPrefs();
- static void RegisterUserPrefs(PrefServiceSyncable* prefs);
+ static void RegisterUserPrefs(PrefService* prefs,
+ PrefRegistrySyncable* registry);
// Checks if sync is enabled for the profile that owns |io_data|. This must
// be invoked on the IO thread, and can be used to check if sync is enabled
@@ -131,7 +133,7 @@ class SyncPrefs : NON_EXPORTED_BASE(public base::NonThreadSafe),
void RegisterPrefGroups();
static void RegisterDataTypePreferredPref(
- PrefServiceSyncable* prefs, syncer::ModelType type, bool is_preferred);
+ PrefRegistrySyncable* prefs, syncer::ModelType type, bool is_preferred);
bool GetDataTypePreferred(syncer::ModelType type) const;
void SetDataTypePreferred(syncer::ModelType type, bool is_preferred);
@@ -144,7 +146,7 @@ class SyncPrefs : NON_EXPORTED_BASE(public base::NonThreadSafe),
void OnSyncManagedPrefChanged();
// May be NULL.
- PrefServiceSyncable* const pref_service_;
+ PrefService* const pref_service_;
ObserverList<SyncPrefObserver> sync_pref_observers_;
« no previous file with comments | « chrome/browser/sync/profile_sync_service_preference_unittest.cc ('k') | chrome/browser/sync/sync_prefs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698