Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: chrome/browser/sync/invalidations/invalidator_storage.h

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/invalidations/invalidator_storage.h
diff --git a/chrome/browser/sync/invalidations/invalidator_storage.h b/chrome/browser/sync/invalidations/invalidator_storage.h
index 0252810c3e3ce8f7025d4aa6f7dc06babba97733..31cca1298c962f644b97f80f1fc8bfd8c4e6b0b4 100644
--- a/chrome/browser/sync/invalidations/invalidator_storage.h
+++ b/chrome/browser/sync/invalidations/invalidator_storage.h
@@ -15,7 +15,8 @@
#include "base/threading/thread_checker.h"
#include "sync/notifier/invalidation_state_tracker.h"
-class PrefServiceSyncable;
+class PrefService;
+class PrefRegistrySyncable;
namespace base {
class DictionaryValue;
@@ -34,7 +35,8 @@ class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>,
public:
// |pref_service| may be NULL (for unit tests), but in that case no setter
// methods should be called. Does not own |pref_service|.
- explicit InvalidatorStorage(PrefServiceSyncable* pref_service);
+ explicit InvalidatorStorage(PrefService* pref_service,
+ PrefRegistrySyncable* registry);
virtual ~InvalidatorStorage();
// Erases invalidation versions and state stored on disk.
@@ -90,12 +92,12 @@ class InvalidatorStorage : public base::SupportsWeakPtr<InvalidatorStorage>,
// Code for migrating from old MaxInvalidationVersions pref, which was a map
// from sync types to max invalidation versions.
- void MigrateMaxInvalidationVersionsPref();
+ void MigrateMaxInvalidationVersionsPref(PrefRegistrySyncable* registry);
static void DeserializeMap(const base::DictionaryValue* max_versions_dict,
syncer::InvalidationStateMap* map);
// May be NULL.
- PrefServiceSyncable* const pref_service_;
+ PrefService* const pref_service_;
DISALLOW_COPY_AND_ASSIGN(InvalidatorStorage);
};
« no previous file with comments | « chrome/browser/sync/glue/sync_backend_host_unittest.cc ('k') | chrome/browser/sync/invalidations/invalidator_storage.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698