Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2723)

Unified Diff: chrome/browser/profiles/profile_impl.h

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_impl.h
diff --git a/chrome/browser/profiles/profile_impl.h b/chrome/browser/profiles/profile_impl.h
index b1f23f79793703f29d942f05e247c9b409b14f38..6470a658f81ddca638ee034411f8fb4abc137ccd 100644
--- a/chrome/browser/profiles/profile_impl.h
+++ b/chrome/browser/profiles/profile_impl.h
@@ -20,8 +20,10 @@
#include "content/public/browser/host_zoom_map.h"
class NetPrefObserver;
-class PrefServiceSyncable;
+class PrefRegistrySyncable;
+class PrefService;
class PrefServiceBase;
+class PrefServiceSyncable;
class SSLConfigServiceManager;
#if defined(OS_CHROMEOS)
@@ -56,7 +58,7 @@ class ProfileImpl : public Profile {
virtual ~ProfileImpl();
- static void RegisterUserPrefs(PrefServiceSyncable* prefs);
+ static void RegisterUserPrefs(PrefRegistrySyncable* registry);
// content::BrowserContext implementation:
virtual base::FilePath GetPath() OVERRIDE;
@@ -95,8 +97,8 @@ class ProfileImpl : public Profile {
virtual policy::ManagedModePolicyProvider*
GetManagedModePolicyProvider() OVERRIDE;
virtual policy::PolicyService* GetPolicyService() OVERRIDE;
- virtual PrefServiceSyncable* GetPrefs() OVERRIDE;
- virtual PrefServiceSyncable* GetOffTheRecordPrefs() OVERRIDE;
+ virtual PrefService* GetPrefs() OVERRIDE;
+ virtual PrefService* GetOffTheRecordPrefs() OVERRIDE;
virtual net::URLRequestContextGetter*
GetRequestContextForExtensions() OVERRIDE;
virtual net::SSLConfigService* GetSSLConfigService() OVERRIDE;
@@ -231,6 +233,7 @@ class ProfileImpl : public Profile {
// Keep |prefs_| on top for destruction order because |extension_prefs_|,
// |net_pref_observer_|, |io_data_| an others store pointers to |prefs_| and
// shall be destructed first.
+ scoped_refptr<PrefRegistrySyncable> pref_registry_;
scoped_ptr<PrefServiceSyncable> prefs_;
scoped_ptr<PrefServiceSyncable> otr_prefs_;
ProfileImplIOData::Handle io_data_;
« no previous file with comments | « chrome/browser/profiles/profile.cc ('k') | chrome/browser/profiles/profile_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698