Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1807)

Unified Diff: chrome/browser/prefs/pref_service.h

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/prefs/pref_registry_syncable.cc ('k') | chrome/browser/prefs/pref_service_mock_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prefs/pref_service.h
diff --git a/chrome/browser/prefs/pref_service.h b/chrome/browser/prefs/pref_service.h
index 0d11873458a5d51c8cf80d3448846c31792941e4..9ea3787751571ab5275358c392088c09fd483aa1 100644
--- a/chrome/browser/prefs/pref_service.h
+++ b/chrome/browser/prefs/pref_service.h
@@ -183,7 +183,8 @@ class PrefService : public PrefServiceBase, public base::NonThreadSafe {
void AddRegisteredPreference(const char* path,
base::Value* default_value);
- void RemoveRegisteredPreference(const char* path);
+ // Updates local caches for a preference unregistered at |path|.
+ virtual void RemoveRegisteredPreference(const char* path);
// The PrefNotifier handles registering and notifying preference observers.
// It is created and owned by this PrefService. Subclasses may access it for
@@ -255,9 +256,4 @@ class PrefService : public PrefServiceBase, public base::NonThreadSafe {
DISALLOW_COPY_AND_ASSIGN(PrefService);
};
-// TODO(joi): Remove these forwards. They were placed here temporarily
-// to limit the size of the initial change that split
-// PrefServiceSimple and PrefServiceSyncable out of PrefService.
-#include "chrome/browser/prefs/pref_service_syncable.h"
-
#endif // CHROME_BROWSER_PREFS_PREF_SERVICE_H_
« no previous file with comments | « chrome/browser/prefs/pref_registry_syncable.cc ('k') | chrome/browser/prefs/pref_service_mock_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698