Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(971)

Side by Side Diff: chrome/browser/prefs/scoped_user_pref_update_unittest.cc

Issue 12079097: Introduce PrefRegistrySyncable, simplifying PrefServiceSyncable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge to head again; base::File changes conflicted. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/prefs/public/pref_change_registrar.h" 5 #include "base/prefs/public/pref_change_registrar.h"
6 #include "chrome/browser/prefs/mock_pref_change_callback.h" 6 #include "chrome/browser/prefs/mock_pref_change_callback.h"
7 #include "chrome/browser/prefs/pref_registry_syncable.h"
7 #include "chrome/browser/prefs/scoped_user_pref_update.h" 8 #include "chrome/browser/prefs/scoped_user_pref_update.h"
8 #include "chrome/test/base/testing_pref_service.h" 9 #include "chrome/test/base/testing_pref_service.h"
9 #include "testing/gmock/include/gmock/gmock.h" 10 #include "testing/gmock/include/gmock/gmock.h"
10 #include "testing/gtest/include/gtest/gtest.h" 11 #include "testing/gtest/include/gtest/gtest.h"
11 12
12 using testing::_; 13 using testing::_;
13 using testing::Mock; 14 using testing::Mock;
14 15
15 class ScopedUserPrefUpdateTest : public testing::Test { 16 class ScopedUserPrefUpdateTest : public testing::Test {
16 public: 17 public:
17 ScopedUserPrefUpdateTest() : observer_(&prefs_) {} 18 ScopedUserPrefUpdateTest() : observer_(&prefs_) {}
18 virtual ~ScopedUserPrefUpdateTest() {} 19 virtual ~ScopedUserPrefUpdateTest() {}
19 20
20 protected: 21 protected:
21 virtual void SetUp() { 22 virtual void SetUp() {
22 prefs_.RegisterDictionaryPref(kPref, 23 prefs_.registry()->RegisterDictionaryPref(
23 PrefServiceSyncable::UNSYNCABLE_PREF); 24 kPref,
25 PrefRegistrySyncable::UNSYNCABLE_PREF);
24 registrar_.Init(&prefs_); 26 registrar_.Init(&prefs_);
25 registrar_.Add(kPref, observer_.GetCallback()); 27 registrar_.Add(kPref, observer_.GetCallback());
26 } 28 }
27 29
28 static const char kPref[]; 30 static const char kPref[];
29 static const char kKey[]; 31 static const char kKey[];
30 static const char kValue[]; 32 static const char kValue[];
31 33
32 TestingPrefServiceSyncable prefs_; 34 TestingPrefServiceSyncable prefs_;
33 MockPrefChangeCallback observer_; 35 MockPrefChangeCallback observer_;
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 TEST_F(ScopedUserPrefUpdateTest, NeverTouchAnything) { 74 TEST_F(ScopedUserPrefUpdateTest, NeverTouchAnything) {
73 const DictionaryValue* old_value = prefs_.GetDictionary(kPref); 75 const DictionaryValue* old_value = prefs_.GetDictionary(kPref);
74 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0); 76 EXPECT_CALL(observer_, OnPreferenceChanged(_)).Times(0);
75 { 77 {
76 DictionaryPrefUpdate update(&prefs_, kPref); 78 DictionaryPrefUpdate update(&prefs_, kPref);
77 } 79 }
78 const DictionaryValue* new_value = prefs_.GetDictionary(kPref); 80 const DictionaryValue* new_value = prefs_.GetDictionary(kPref);
79 EXPECT_EQ(old_value, new_value); 81 EXPECT_EQ(old_value, new_value);
80 Mock::VerifyAndClearExpectations(&observer_); 82 Mock::VerifyAndClearExpectations(&observer_);
81 } 83 }
OLDNEW
« no previous file with comments | « chrome/browser/prefs/proxy_policy_unittest.cc ('k') | chrome/browser/prefs/session_startup_pref.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698