cc: Fix RasterWorkerPool shutdown crash.

cc: Fix RasterWorkerPool shutdown crash.

Avoid calling sort on the raster thread vector while deleting its
elements. This also adds a "IsRunning" state that is used to
check that that the worker pool is not used incorrectly during
shutdown.

BUG=172059
R=nduca@chromium.org
NOTRY=true

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179321

[reveman, 2013-01-28 17:30:02]

I was able to reproduce this by killing the gpu process on desktop but the same
thing should happen whenever we destroy the tile manager and its worker pool.

[nduca, 2013-01-29 00:13:08]

lgtm

https://codereview.chromium.org/12079028/diff/1/cc/raster_worker_pool.cc
File cc/raster_worker_pool.cc (right):

https://codereview.chromium.org/12079028/diff/1/cc/raster_worker_pool.cc#newc...
cc/raster_worker_pool.cc:231: if (!raster_threads_need_sorting_)
Out of curiosity, what does this do?

[reveman, 2013-01-29 02:49:54]

https://codereview.chromium.org/12079028/diff/1/cc/raster_worker_pool.cc
File cc/raster_worker_pool.cc (right):

https://codereview.chromium.org/12079028/diff/1/cc/raster_worker_pool.cc#newc...
cc/raster_worker_pool.cc:231: if (!raster_threads_need_sorting_)
On 2013/01/29 00:13:08, nduca wrote:
> Out of curiosity, what does this do?

Rather than having iterate over all threads both when IsBusy is called and when
posting a task I keep the thread vector sorted by number of pending tasks. I
don't expect it have a significant perf impact with any reasonable number of
threads but I find it a bit cleaner like this for now.

We might remove the IsBusy() function sometime soon and this sorting will
probably go as well then.

[nduca, 2013-01-29 02:50:29]

Yeah makes sense. Still lgtm.

[commit-bot: I haz the power, 2013-01-29 02:51:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/12079028/1

[commit-bot: I haz the power, 2013-01-29 03:14:53]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-29 05:33:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/12079028/1

[commit-bot: I haz the power, 2013-01-29 05:49:17]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-01-29 12:31:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/12079028/1

[commit-bot: I haz the power, 2013-01-29 12:31:52]

Change committed as 179321