src/type-info.cc - Issue 12079024: Tag previously GENERIC stubs that potentially IC_Miss as MONOMORPHIC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/type-info.cc

Issue 12079024: Tag previously GENERIC stubs that potentially IC_Miss as MONOMORPHIC. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Replace explicit stub-check with != GENERIC check. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/type-info.cc

diff --git a/src/type-info.cc b/src/type-info.cc

index fb0f45a416791fa8c5e27b93eedaa9e197261f6e..80d3434c97fe40b37eb22baa41ec459902a71a5c 100644

--- a/src/type-info.cc

+++ b/src/type-info.cc

@@ -493,8 +493,7 @@ void TypeFeedbackOracle::CollectReceiverTypes(TypeFeedbackId ast_id,

Handle<Object> object = GetInfo(ast_id);

if (object->IsUndefined() || object->IsSmi()) return;

- if (*object ==

- isolate_->builtins()->builtin(Builtins::kStoreIC_GlobalProxy)) {

+ if (object.is_identical_to(isolate_->builtins()->StoreIC_GlobalProxy())) {

// TODO(fschneider): We could collect the maps and signal that

// we need a generic store (or load) here.

ASSERT(Handle<Code>::cast(object)->ic_state() == GENERIC);

« no previous file with comments | « src/ic.cc ('k') | no next file » | no next file with comments »