Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(924)

Issue 12079024: Tag previously GENERIC stubs that potentially IC_Miss as MONOMORPHIC. (Closed)

Created:
7 years, 10 months ago by Toon Verwaest
Modified:
7 years, 10 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Tag previously GENERIC stubs that potentially IC_Miss as MONOMORPHIC. Committed: https://code.google.com/p/v8/source/detail?r=13537

Patch Set 1 #

Patch Set 2 : Explicitly mark GENERIC as UNREACHABLE. #

Patch Set 3 : Replace explicit stub-check with != GENERIC check. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M src/builtins.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ic.cc View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M src/type-info.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Toon Verwaest
PTAL. This ensures we miss GENERIC ICs.
7 years, 10 months ago (2013-01-28 14:55:51 UTC) #1
Jakob Kummerow
7 years, 10 months ago (2013-01-29 10:43:11 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698