Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/sync_file_system/local_file_sync_service_unittest.cc

Issue 12078002: Disable LocalChangeObserverMultipleContexts instead of marking it flaky (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/bind.h" 6 #include "base/bind.h"
7 #include "base/file_util.h" 7 #include "base/file_util.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/message_loop_proxy.h" 9 #include "base/message_loop_proxy.h"
10 #include "base/run_loop.h" 10 #include "base/run_loop.h"
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 EXPECT_EQ(base::PLATFORM_FILE_OK, file_system_->CreateDirectory(kDir)); 273 EXPECT_EQ(base::PLATFORM_FILE_OK, file_system_->CreateDirectory(kDir));
274 EXPECT_EQ(kTestFileDataSize, 274 EXPECT_EQ(kTestFileDataSize,
275 file_system_->WriteString(kFile, kTestFileData)); 275 file_system_->WriteString(kFile, kTestFileData));
276 276
277 EXPECT_EQ(2, num_changes_); 277 EXPECT_EQ(2, num_changes_);
278 } 278 }
279 279
280 #if defined(OS_WIN) && defined(USE_AURA) 280 #if defined(OS_WIN) && defined(USE_AURA)
281 // Flaky: http://crbug.com/171487 281 // Flaky: http://crbug.com/171487
282 #define MAYBE_LocalChangeObserverMultipleContexts\ 282 #define MAYBE_LocalChangeObserverMultipleContexts\
283 FLAKY_LocalChangeObserverMultipleContexts 283 DISABLED_LocalChangeObserverMultipleContexts
284 #else 284 #else
285 #define MAYBE_LocalChangeObserverMultipleContexts\ 285 #define MAYBE_LocalChangeObserverMultipleContexts\
286 LocalChangeObserverMultipleContexts 286 LocalChangeObserverMultipleContexts
287 #endif 287 #endif
288 288
289 TEST_F(LocalFileSyncServiceTest, MAYBE_LocalChangeObserverMultipleContexts) { 289 TEST_F(LocalFileSyncServiceTest, MAYBE_LocalChangeObserverMultipleContexts) {
290 const char kOrigin2[] = "http://foo"; 290 const char kOrigin2[] = "http://foo";
291 fileapi::CannedSyncableFileSystem file_system2( 291 fileapi::CannedSyncableFileSystem file_system2(
292 GURL(kOrigin2), kServiceName, 292 GURL(kOrigin2), kServiceName,
293 thread_helper_.io_task_runner(), 293 thread_helper_.io_task_runner(),
(...skipping 266 matching lines...) Expand 10 before | Expand all | Expand 10 after
560 } 560 }
561 561
562 EXPECT_EQ(1U, changes.size()); 562 EXPECT_EQ(1U, changes.size());
563 EXPECT_EQ(change, changes[0]); 563 EXPECT_EQ(change, changes[0]);
564 } 564 }
565 565
566 // TODO(kinuko): Add tests for multiple file changes and multiple 566 // TODO(kinuko): Add tests for multiple file changes and multiple
567 // FileSystemContexts. 567 // FileSystemContexts.
568 568
569 } // namespace sync_file_system 569 } // namespace sync_file_system
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698