Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Issue 12077029: Removing the Dev channel restriction for requestBody of Web Request API. (Closed)

Created:
7 years, 10 months ago by vabr (Chromium)
Modified:
7 years, 10 months ago
Reviewers:
Matt Perry, battre
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Removing the Dev channel restriction for requestBody of Web Request API. The 'requestBody' feature of the Web Request API has now been some time in Dev and Canary channels. It has been used by extension developers, as documented on the associated bug, and on https://chrome.google.com/webstore/detail/observepoint-tag-debugger/daejfbkjipkgidckemjjafiomfeabemo . BUG=91191 TBR=mpcomplete@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179147

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -97 lines) Patch
M chrome/browser/extensions/api/web_request/web_request_api.cc View 2 chunks +1 line, -8 lines 0 comments Download
M chrome/browser/extensions/api/web_request/web_request_api_unittest.cc View 9 chunks +53 lines, -84 lines 1 comment Download
M chrome/browser/extensions/api/web_request/web_request_apitest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/web_request.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
vabr (Chromium)
Dominic, Does this look good to you? Matt, Cc-ing you as promised. Also, I need ...
7 years, 10 months ago (2013-01-28 10:26:14 UTC) #1
battre
lgtm
7 years, 10 months ago (2013-01-28 10:41:30 UTC) #2
vabr (Chromium)
Thanks Dominic! Since Matt agreed with this push in an e-mail, and the change in ...
7 years, 10 months ago (2013-01-28 13:25:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/12077029/1
7 years, 10 months ago (2013-01-28 13:25:57 UTC) #4
commit-bot: I haz the power
7 years, 10 months ago (2013-01-28 14:55:55 UTC) #5
Message was sent while issue was closed.
Change committed as 179147

Powered by Google App Engine
This is Rietveld 408576698