Reland r179081 (Make build/temp_gyp/googleurl a 'none' target that depends on the 'real' src/google…

Reland r179081 (Make build/temp_gyp/googleurl a 'none' target that depends on the 'real' src/googleurl/googleurl.gyp).

R=rsleevi@chromium.org
TBR=rsleevi@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179097

[tfarina, 2013-01-28 02:19:06]

TBRing... as it's the same as the original per discussion on irc.

[commit-bot: I haz the power, 2013-01-28 02:20:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12077023/1

[commit-bot: I haz the power, 2013-01-28 03:57:40]

Change committed as 179097

[boliu, 2013-01-28 05:13:37]

This is breaking downstream android webview build because the gyp generator for
android build system is strict about escaping the target path. Is it possible to
make all the dependencies point to src/googleurl/googleurl.gyp first (including
ones in webkit) before modifying or removing src/build/temp_gyp/googleurl.gyp?

The other option is to land this gyp patch until all of this is fixed:
https://codereview.chromium.org/12088017

[Ryan Sleevi, 2013-01-28 05:25:27]

On 2013/01/28 05:13:37, boliu wrote:
> This is breaking downstream android webview build because the gyp generator
for
> android build system is strict about escaping the target path. Is it possible
to
> make all the dependencies point to src/googleurl/googleurl.gyp first
(including
> ones in webkit) before modifying or removing src/build/temp_gyp/googleurl.gyp?
> 
> The other option is to land this gyp patch until all of this is fixed:
> https://codereview.chromium.org/12088017

Following up on IM, as this shouldn't be causing issues for Android or GYP

[Ryan Sleevi, 2013-01-28 05:45:14]

Ok, I was relying on Brett's initial stamps for the overall design, but now I'm
convinced this is bad.

Your change to googleurl (
https://code.google.com/p/google-url/source/detail?r=182 ) doesn't make the GYP
files any more maintainable - it makes them significantly less maintainable.

We already have this headache with webrtc, v8, and WebKit, but unless there are
significant benefits here (and there are, for those projects, since they all
have standalone builds), then the sort of "Chromium GYP in GoogleURL" just makes
more maintenance headache.

This is the same reason we do not split base/, net/, etc into their own source
control systems - it makes refactoring significantly harder.

Lets revert this, and don't reland it, and ideally revert drover r182.

(FWIW, the reason it was failing was because google-url GYP is wrong. It's
setting include_dirs to be '../..', rather than '..', which reflects its new
place in src/googleurl rather than in src/build/temp_gyp)