Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 12059002: Remove -DPREFIX from win64 yasm_compile.gypi to fix ffmpeg linking (Closed)

Created:
7 years, 11 months ago by wolenetz
Modified:
7 years, 11 months ago
CC:
chromium-reviews, DaleCurtis
Visibility:
Public.

Description

Remove -DPREFIX from win64 yasm_compile.gypi to fix ffmpeg linking BUG=171542, 171721, 166496 TEST=ffmpegsumo target builds on win64 with private fix to disable ffmpeg compiler warning 4267 on win64 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178429

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebased PS1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M third_party/yasm/yasm_compile.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
wolenetz
I don't have a working libvpx build (or private), so I don't know if this ...
7 years, 11 months ago (2013-01-22 23:31:19 UTC) #1
wolenetz
https://codereview.chromium.org/12059002/diff/1/third_party/yasm/yasm_compile.gypi File third_party/yasm/yasm_compile.gypi (left): https://codereview.chromium.org/12059002/diff/1/third_party/yasm/yasm_compile.gypi#oldcode73 third_party/yasm/yasm_compile.gypi:73: '-DPREFIX', try bots are failing update. I'll sync my ...
7 years, 11 months ago (2013-01-22 23:39:58 UTC) #2
fgalligan1
lgtm
7 years, 11 months ago (2013-01-23 18:24:47 UTC) #3
wolenetz
jschuh & scherkus: please review Thanks!
7 years, 11 months ago (2013-01-23 18:30:13 UTC) #4
scherkus (not reviewing)
rubber stamp lgtm (but I know nothing about yasm gyp!)
7 years, 11 months ago (2013-01-23 19:06:24 UTC) #5
jschuh
On 2013/01/23 18:30:13, wolenetz wrote: > jschuh & scherkus: please review > > Thanks! lgtm. ...
7 years, 11 months ago (2013-01-23 19:20:18 UTC) #6
jschuh
On 2013/01/23 19:20:18, Justin Schuh wrote: > lgtm. If Andrew doesn't respond soon I doubt ...
7 years, 11 months ago (2013-01-23 19:20:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12059002/3002
7 years, 11 months ago (2013-01-23 19:25:52 UTC) #8
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=91960
7 years, 11 months ago (2013-01-23 21:55:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wolenetz@chromium.org/12059002/3002
7 years, 11 months ago (2013-01-23 22:22:31 UTC) #10
commit-bot: I haz the power
7 years, 11 months ago (2013-01-23 23:44:29 UTC) #11
Message was sent while issue was closed.
Change committed as 178429

Powered by Google App Engine
This is Rietveld 408576698