Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 12052065: Add components_unittests to android fyi bots (Closed)

Created:
7 years, 11 months ago by boliu
Modified:
7 years, 11 months ago
Reviewers:
Isaac (away), kaiwang, Jói
CC:
chromium-reviews, klundberg+watch_chromium.org, frankf+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy+watch_chromium.org
Visibility:
Public.

Description

Add components_unittests to android fyi bots These are not new tests, just existing tests that has moved to a new target under components. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178696

Patch Set 1 #

Patch Set 2 : Add new test target to android ALl target #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M build/all_android.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/pylib/gtest/gtest_config.py View 1 chunk +1 line, -0 lines 0 comments Download
M components/components_tests.gypi View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
boliu
Isaac: As these are not new tests, I'll watch these on the fyi bots for ...
7 years, 11 months ago (2013-01-24 18:55:39 UTC) #1
Isaac (away)
Yep, LGTM.
7 years, 11 months ago (2013-01-24 19:08:47 UTC) #2
Jói
LGTM
7 years, 11 months ago (2013-01-24 19:21:53 UTC) #3
kaiwang
LGTM
7 years, 11 months ago (2013-01-24 19:40:49 UTC) #4
boliu
fyi everyone, I forgot to add it to the android All target, fixed in PS2
7 years, 11 months ago (2013-01-24 19:44:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/12052065/7001
7 years, 11 months ago (2013-01-24 20:38:47 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-24 23:44:31 UTC) #7
Message was sent while issue was closed.
Change committed as 178696

Powered by Google App Engine
This is Rietveld 408576698