Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 12051022: Add a heuristic to skip git checkouts not managed by crup (Closed)

Created:
7 years, 11 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 11 months ago
Reviewers:
szager1
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

Add a heuristic to skip git checkouts not managed by crup BUG=171500 R=szager@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=178350

Patch Set 1 #

Total comments: 2

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M crup-runner.sh View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
7 years, 11 months ago (2013-01-22 21:22:27 UTC) #1
szager1
Thanks for looking at this. https://codereview.chromium.org/12051022/diff/1/crup-runner.sh File crup-runner.sh (right): https://codereview.chromium.org/12051022/diff/1/crup-runner.sh#newcode66 crup-runner.sh:66: if ! grep -q ...
7 years, 11 months ago (2013-01-23 17:22:46 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/12051022/diff/1/crup-runner.sh File crup-runner.sh (right): https://codereview.chromium.org/12051022/diff/1/crup-runner.sh#newcode66 crup-runner.sh:66: if ! grep -q -s "The Chromium Authors" ".git/description"; ...
7 years, 11 months ago (2013-01-23 17:55:50 UTC) #3
szager1
https://codereview.chromium.org/12051022/diff/4001/crup-runner.sh File crup-runner.sh (right): https://codereview.chromium.org/12051022/diff/4001/crup-runner.sh#newcode69 crup-runner.sh:69: exit 0 Let's add this too: echo "Skipping unmanaged ...
7 years, 11 months ago (2013-01-23 18:18:10 UTC) #4
jochen (gone - plz use gerrit)
done
7 years, 11 months ago (2013-01-23 19:01:28 UTC) #5
szager1
lgtm
7 years, 11 months ago (2013-01-23 19:10:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12051022/8001
7 years, 11 months ago (2013-01-23 19:34:25 UTC) #7
commit-bot: I haz the power
7 years, 11 months ago (2013-01-23 19:36:56 UTC) #8
Message was sent while issue was closed.
Change committed as 178350

Powered by Google App Engine
This is Rietveld 408576698