content/browser/web_contents/web_contents_android.cc - Issue 1205033005: Adds selection expansion support for Contextual Search.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_android.cc

Issue 1205033005: Adds selection expansion support for Contextual Search. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix expansions Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/android/contextualsearch/contextual_search_delegate.cc ('K') | « content/browser/web_contents/web_contents_android.h ('k') | content/common/view_messages.h » ('j') | content/renderer/render_view_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_android.cc

diff --git a/content/browser/web_contents/web_contents_android.cc b/content/browser/web_contents/web_contents_android.cc

index 099e62db1b7320f35352c2a4eca7f1662d7567a7..d26fe659dcebe16819ecbdd6530aea6ae836d469 100644

--- a/content/browser/web_contents/web_contents_android.cc

+++ b/content/browser/web_contents/web_contents_android.cc

@@ -395,6 +395,16 @@ void WebContentsAndroid::SelectWordAroundCaret(JNIEnv* env, jobject obj) {

host->SelectWordAroundCaret();

}

+void WebContentsAndroid::ExpandSelectionByCharacterOffset(JNIEnv* env,

+ jobject obj,

+ jint start_adjust,

+ jint end_adjust) {

+ RenderViewHost* host = web_contents_->GetRenderViewHost();

+ if (!host)

+ return;

+ host->ExpandSelectionByCharacterOffset(start_adjust, end_adjust);

void WebContentsAndroid::EvaluateJavaScript(JNIEnv* env,

jobject obj,

jstring script,