Adds selection expansion support for Contextual Search.

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/auto_reset.h"
@@ skipping 1339 matching lines @@
         OnGetSerializedHtmlDataForCurrentPageWithLocalLinks)
     IPC_MESSAGE_HANDLER(ViewMsg_ShowContextMenu, OnShowContextMenu)
     // TODO(viettrungluu): Move to a separate message filter.
     IPC_MESSAGE_HANDLER(ViewMsg_SetHistoryOffsetAndLength,
                         OnSetHistoryOffsetAndLength)
     IPC_MESSAGE_HANDLER(ViewMsg_EnableViewSourceMode, OnEnableViewSourceMode)
     IPC_MESSAGE_HANDLER(ViewMsg_ReleaseDisambiguationPopupBitmap,
                         OnReleaseDisambiguationPopupBitmap)
     IPC_MESSAGE_HANDLER(ViewMsg_ForceRedraw, OnForceRedraw)
     IPC_MESSAGE_HANDLER(ViewMsg_SelectWordAroundCaret, OnSelectWordAroundCaret)
+    IPC_MESSAGE_HANDLER(ViewMsg_ExpandSelectionByCharacterOffset,
+                        OnExpandSelectionByCharacterOffset)
 #if defined(OS_ANDROID)
     IPC_MESSAGE_HANDLER(InputMsg_ActivateNearestFindResult,
                         OnActivateNearestFindResult)
     IPC_MESSAGE_HANDLER(ViewMsg_FindMatchRects, OnFindMatchRects)
     IPC_MESSAGE_HANDLER(ViewMsg_UpdateTopControlsState,
                         OnUpdateTopControlsState)
     IPC_MESSAGE_HANDLER(ViewMsg_ExtractSmartClipData, OnExtractSmartClipData)
 #elif defined(OS_MACOSX)
     IPC_MESSAGE_HANDLER(ViewMsg_GetRenderedText,
                         OnGetRenderedText)
@@ skipping 16 matching lines @@
 
 void RenderViewImpl::OnSelectWordAroundCaret() {
   if (!webview())
     return;
 
   handling_input_event_ = true;
   webview()->focusedFrame()->selectWordAroundCaret();
   handling_input_event_ = false;
 }
 
+void RenderViewImpl::OnExpandSelectionByCharacterOffset(int start_adjust,
+                                                        int end_adjust) {
+  if (!webview())
+    return;
+
+  handling_input_event_ = true;
+  size_t start, length;
+  if (webview()->caretOrSelectionRange(&start, &length)) {
+    start -= start_adjust;
+    length += end_adjust + start_adjust;
+    WebLocalFrame* web_local_frame =
+        webview()->focusedFrame()->toWebLocalFrame();

[pedro (no code reviews), 2015/07/01 22:18:57]

Please confirm with someone familiar with the WebView if we really need
toWebLocalFrame(), or if we could use instead just focusedFrame() like we do
above for OnSelectWordAroundCaret(). Mounir mentioned that some things are
moving the the local frame, but I don't really understand the difference of the
two.

[aurimas (slooooooooow), 2015/07/01 23:05:44]

Do you have suggestions about who to ask to review this?

[pedro (no code reviews), 2015/07/02 00:09:57]

I would say yoichio@ since he is the one who suggested using this approach:
https://code.google.com/p/chromium/issues/detail?id=396738#c20

+    web_local_frame->selectRange(WebRange::fromDocumentRange(web_local_frame,
+                                                             start,
+                                                             length));
+  }
+  handling_input_event_ = false;
+}
+
 void RenderViewImpl::OnCopyImageAt(int x, int y) {
   webview()->copyImageAt(WebPoint(x, y));
 }
 
 void RenderViewImpl::OnSaveImageAt(int x, int y) {
   webview()->saveImageAt(WebPoint(x, y));
 }
 
 void RenderViewImpl::OnUpdateTargetURLAck() {
   // Check if there is a targeturl waiting to be sent.
@@ skipping 2390 matching lines @@
     std::vector<gfx::Size> sizes;
     ConvertToFaviconSizes(icon_urls[i].sizes(), &sizes);
     if (!url.isEmpty())
       urls.push_back(
           FaviconURL(url, ToFaviconType(icon_urls[i].iconType()), sizes));
   }
   SendUpdateFaviconURL(urls);
 }
 
 }  // namespace content