Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 12049037: MIPS: Avoid handle dereference during graph optimization. (Closed)

Created:
7 years, 11 months ago by palfia
Modified:
7 years, 11 months ago
Reviewers:
kisg, Paul Lind, danno, Yang
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Avoid handle dereference during graph optimization. Port r13475 (0076e1ee) Original commit message: With parallel recompilation enabled, objects made accessible by handles may have changed between graph construction and graph optimization. Therefore we must not assume that information on those objects remain the same between those two phases. To police this, we forbid handle dereferencing during graph optimization. Exceptions to this rule are: - Dereferencing the handle to obtain the raw location of the object. This is safe since parallel recompilation acquires RelocationLock - Some places that dereference the handle for a type check. These are checked to be safe on a case-by-case basis. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=13477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M src/mips/lithium-codegen-mips.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
palfia
7 years, 11 months ago (2013-01-23 15:22:40 UTC) #1
Yang
On 2013/01/23 15:22:40, palfia wrote: LGTM.
7 years, 11 months ago (2013-01-23 15:24:31 UTC) #2
palfia
On 2013/01/23 15:24:31, Yang wrote: > On 2013/01/23 15:22:40, palfia wrote: > > LGTM. Wow, ...
7 years, 11 months ago (2013-01-23 15:31:10 UTC) #3
Yang
7 years, 11 months ago (2013-01-23 15:33:07 UTC) #4
Message was sent while issue was closed.
On 2013/01/23 15:31:10, palfia wrote:
> On 2013/01/23 15:24:31, Yang wrote:
> > On 2013/01/23 15:22:40, palfia wrote:
> > 
> > LGTM.
> 
> Wow, You're as quick as lightning! :)

As are you :)

Powered by Google App Engine
This is Rietveld 408576698