Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Issue 12047066: Reland: Add trace event Pepper API (Closed)

Created:
7 years, 11 months ago by elijahtaylor1
Modified:
7 years, 10 months ago
Reviewers:
brettw
CC:
chromium-reviews, yusukes+watch_chromium.org, yzshen+watch_chromium.org, darin-cc_chromium.org, raymes+watch_chromium.org, piman+watch_chromium.org, erikwright+watch_chromium.org, ihf+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Reland: Add trace event Pepper API This facilitates adding trace data to chrome://tracing from plugins. - broke out trace_event.h into trace_event.h/trace_event_internal.h for easier transplanting to plugin code by eliminating dependence on base/. - inlined trace_event.cc methods (4 total) so the trace_event_internal implementation is contained in headers. - added new PPB_TraceEvent_Dev interface (implemented entirely on the plugin side) BUG=93839 TEST=base_unittests, manual for plugin testing Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179171

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -967 lines) Patch
M base/base.gypi View 1 chunk +1 line, -1 line 0 comments Download
M base/debug/trace_event.h View 2 chunks +14 lines, -876 lines 0 comments Download
D base/debug/trace_event.cc View 1 chunk +0 lines, -28 lines 0 comments Download
A + base/debug/trace_event_internal.h View 9 chunks +35 lines, -60 lines 0 comments Download
A ppapi/api/dev/ppb_trace_event_dev.idl View 1 chunk +50 lines, -0 lines 0 comments Download
A ppapi/c/dev/ppb_trace_event_dev.h View 1 chunk +68 lines, -0 lines 0 comments Download
M ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_shim.c View 6 chunks +13 lines, -0 lines 0 comments Download
M ppapi/ppapi_shared.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_list.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/shared_impl/ppb_instance_shared.cc View 1 chunk +2 lines, -0 lines 0 comments Download
A ppapi/shared_impl/ppb_trace_event_impl.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ppapi/shared_impl/ppb_trace_event_impl.cc View 1 chunk +74 lines, -0 lines 0 comments Download
M ppapi/tests/all_c_includes.h View 3 chunks +3 lines, -2 lines 0 comments Download
M ppapi/thunk/interfaces_ppb_public_dev.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/plugin_module.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
elijahtaylor1
Trying to reland this change (https://codereview.chromium.org/11464005). I submitted a couple weeks ago but was quickly ...
7 years, 11 months ago (2013-01-25 00:16:24 UTC) #1
brettw
What has changed from the previous landing?
7 years, 11 months ago (2013-01-25 00:19:47 UTC) #2
elijahtaylor1
On 2013/01/25 00:19:47, brettw wrote: > What has changed from the previous landing? Literally nothing ...
7 years, 11 months ago (2013-01-25 00:51:57 UTC) #3
brettw
ah, thanks lgtm
7 years, 11 months ago (2013-01-25 05:55:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/12047066/12001
7 years, 11 months ago (2013-01-25 21:30:35 UTC) #5
commit-bot: I haz the power
Presubmit check for 12047066-12001 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 11 months ago (2013-01-25 21:30:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/12047066/12001
7 years, 11 months ago (2013-01-25 21:50:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/elijahtaylor@chromium.org/12047066/12001
7 years, 10 months ago (2013-01-28 18:45:52 UTC) #8
commit-bot: I haz the power
7 years, 10 months ago (2013-01-28 18:46:25 UTC) #9
Message was sent while issue was closed.
Change committed as 179171

Powered by Google App Engine
This is Rietveld 408576698