Issue 12047050: Correctly set kCanBeDivByZero flag for HMathFloorOfDiv.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12047050: Correctly set kCanBeDivByZero flag for HMathFloorOfDiv. (Closed)

Created:
7 years, 11 months ago by ulan

Modified:
7 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Correctly set kCanBeDivByZero flag for HMathFloorOfDiv. After r13289 the divisor can be non-constant, so we should check for zero. BUG=171641 R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13479

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
	M	src/hydrogen-instructions.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
	A +	test/mjsunit/regress/regress-171641.js	View		1 chunk	+8 lines, -8 lines	0 comments	Download

Total messages: 2 (0 generated)

Yang

7 years, 11 months ago (2013-01-23 15:51:04 UTC) #2

On 2013/01/23 15:49:32, ulan wrote:
> Please take a look.

LGTM.