Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12045093: PPAPI: Add locking for PPB_MessageLoop (Closed)

Created:
7 years, 11 months ago by dmichael (off chromium)
Modified:
7 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Visibility:
Public.

Description

PPAPI: Add locking for PPB_MessageLoop BUG=172330 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178970

Patch Set 1 #

Patch Set 2 : Add locking, workaround benign assert #

Patch Set 3 : Just the message loop locking #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ppapi/proxy/ppb_message_loop_proxy.cc View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dmichael (off chromium)
Add locking we missed for all the methods of PPB_MessageLoop that don't use "Enter*". I'm ...
7 years, 11 months ago (2013-01-25 21:04:09 UTC) #1
brettw
lgtm
7 years, 11 months ago (2013-01-25 21:07:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmichael@chromium.org/12045093/7001
7 years, 11 months ago (2013-01-25 21:15:08 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-26 00:52:52 UTC) #4
Message was sent while issue was closed. 
Change committed as 178970

Powered by Google App Engine
This is Rietveld 408576698