Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 12045060: Add wrapper class to media for support of VP9 video, and add a command line flag to enable the supp… (Closed)

Created:
7 years, 11 months ago by Tom Finegan
Modified:
7 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, (unused - use chromium), vigneshv, fgalligan, jimbankoski
Visibility:
Public.

Description

Add wrapper class to media for support of VP9 video, and add a command line flag to enable the support. This initial version of the wrapper provides support for decoding VP9 video in WebM container files, and is disabled by default. New flag added: --enable-vp9-playback TBR=brettw,scherkus,xhwang BUG=166094 TEST=VP9 video in WebM containers plays back in <video> elements when --enable-vp9-playback is specified on the command line. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178799

Patch Set 1 #

Patch Set 2 : Rebased. #

Total comments: 2

Patch Set 3 : Add EoS DCHECK in VpxVideoDecoder::Decode(). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+436 lines, -38 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M media/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/media_switches.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M media/base/video_decoder_config.h View 2 chunks +6 lines, -2 lines 0 comments Download
M media/ffmpeg/ffmpeg_common.cc View 3 chunks +22 lines, -3 lines 0 comments Download
A + media/filters/vpx_video_decoder.h View 4 chunks +24 lines, -33 lines 0 comments Download
A media/filters/vpx_video_decoder.cc View 1 2 1 chunk +341 lines, -0 lines 0 comments Download
M media/media.gyp View 1 3 chunks +16 lines, -0 lines 0 comments Download
M webkit/media/filter_helpers.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Tom Finegan
Relanding VP9 support.
7 years, 11 months ago (2013-01-24 20:27:43 UTC) #1
scherkus (not reviewing)
lgtm
7 years, 11 months ago (2013-01-24 21:23:28 UTC) #2
brettw
LGTM. I only looked at non-media/ stuff.
7 years, 11 months ago (2013-01-24 21:32:13 UTC) #3
xhwang
lgtm % comment https://codereview.chromium.org/12045060/diff/4007/media/filters/vpx_video_decoder.cc File media/filters/vpx_video_decoder.cc (right): https://codereview.chromium.org/12045060/diff/4007/media/filters/vpx_video_decoder.cc#newcode267 media/filters/vpx_video_decoder.cc:267: DCHECK(video_frame); Can we DCHECK(!buffer->IsEndOfStream) here? Just ...
7 years, 11 months ago (2013-01-24 22:33:32 UTC) #4
Tom Finegan
https://codereview.chromium.org/12045060/diff/4007/media/filters/vpx_video_decoder.cc File media/filters/vpx_video_decoder.cc (right): https://codereview.chromium.org/12045060/diff/4007/media/filters/vpx_video_decoder.cc#newcode267 media/filters/vpx_video_decoder.cc:267: DCHECK(video_frame); On 2013/01/24 22:33:32, xhwang wrote: > Can we ...
7 years, 11 months ago (2013-01-24 23:39:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tomfinegan@chromium.org/12045060/5003
7 years, 11 months ago (2013-01-25 00:56:13 UTC) #6
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=92796
7 years, 11 months ago (2013-01-25 03:31:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tomfinegan@chromium.org/12045060/5003
7 years, 11 months ago (2013-01-25 04:11:51 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 09:26:18 UTC) #9
Message was sent while issue was closed.
Change committed as 178799

Powered by Google App Engine
This is Rietveld 408576698