Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4382)

Unified Diff: chrome/common/extensions/extension_file_util_unittest.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_file_util.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_file_util_unittest.cc
diff --git a/chrome/common/extensions/extension_file_util_unittest.cc b/chrome/common/extensions/extension_file_util_unittest.cc
index 9147af4cd02b84c84a794249319a8e609e2c6f50..25ed860341f1713081a9c424790721879caed939 100644
--- a/chrome/common/extensions/extension_file_util_unittest.cc
+++ b/chrome/common/extensions/extension_file_util_unittest.cc
@@ -12,6 +12,7 @@
#include "base/utf_string_conversions.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/extensions/api/extension_action/browser_action_handler.h"
+#include "chrome/common/extensions/api/extension_action/page_action_handler.h"
#include "chrome/common/extensions/api/i18n/default_locale_handler.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
@@ -32,8 +33,14 @@ class ExtensionFileUtilTest : public testing::Test {
virtual void SetUp() OVERRIDE {
testing::Test::SetUp();
extensions::ManifestHandler::Register(
- extension_manifest_keys::kBrowserAction,
+ keys::kBrowserAction,
make_linked_ptr(new extensions::BrowserActionHandler));
+ linked_ptr<extensions::PageActionHandler> page_action_handler(
+ new extensions::PageActionHandler);
+ extensions::ManifestHandler::Register(keys::kPageAction,
+ page_action_handler);
+ extensions::ManifestHandler::Register(keys::kPageActions,
+ page_action_handler);
extensions::ManifestHandler::Register(
keys::kDefaultLocale,
make_linked_ptr(new extensions::DefaultLocaleHandler));
« no previous file with comments | « chrome/common/extensions/extension_file_util.cc ('k') | chrome/common/extensions/extension_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698