Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: chrome/common/extensions/api/omnibox/omnibox_handler.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/omnibox/omnibox_handler.h ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/omnibox/omnibox_handler.cc
diff --git a/chrome/common/extensions/api/omnibox/omnibox_handler.cc b/chrome/common/extensions/api/omnibox/omnibox_handler.cc
index 32c406991e3719110f2ed4aefba2dc14c154a98b..60ab76106c5166e9f8fb88b80eeb65c918218f22 100644
--- a/chrome/common/extensions/api/omnibox/omnibox_handler.cc
+++ b/chrome/common/extensions/api/omnibox/omnibox_handler.cc
@@ -8,8 +8,6 @@
#include "base/string_util.h"
#include "base/utf_string_conversions.h"
#include "base/values.h"
-#include "chrome/common/extensions/api/commands/commands_handler.h"
-#include "chrome/common/extensions/api/extension_action/action_info.h"
#include "chrome/common/extensions/extension.h"
#include "chrome/common/extensions/extension_manifest_constants.h"
#include "chrome/common/extensions/manifest.h"
@@ -30,15 +28,6 @@ const std::string& OmniboxInfo::GetKeyword(const Extension* extension) {
return info ? info->keyword : EmptyString();
}
-// static
-bool OmniboxInfo::IsVerboseInstallMessage(const Extension* extension) {
- return !GetKeyword(extension).empty() ||
- ActionInfo::GetBrowserActionInfo(extension) ||
- (extension->page_action_info() &&
- (CommandsInfo::GetPageActionCommand(extension) ||
- !extension->page_action_info()->default_icon.empty()));
-}
-
OmniboxHandler::OmniboxHandler() {
}
« no previous file with comments | « chrome/common/extensions/api/omnibox/omnibox_handler.h ('k') | chrome/common/extensions/extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698