Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4812)

Unified Diff: chrome/common/extensions/api/extension_action/page_action_handler.h

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/api/extension_action/page_action_handler.h
diff --git a/chrome/common/extensions/api/extension_action/browser_action_handler.h b/chrome/common/extensions/api/extension_action/page_action_handler.h
similarity index 50%
copy from chrome/common/extensions/api/extension_action/browser_action_handler.h
copy to chrome/common/extensions/api/extension_action/page_action_handler.h
index e204a224515fdd9d16a56c067ec6846a94bb0305..d770a14a1480f3f81c0f64d571765544d5194676 100644
--- a/chrome/common/extensions/api/extension_action/browser_action_handler.h
+++ b/chrome/common/extensions/api/extension_action/page_action_handler.h
@@ -1,9 +1,9 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_BROWSER_ACTION_HANDLER_H_
-#define CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_BROWSER_ACTION_HANDLER_H_
+#ifndef CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_PAGE_ACTION_HANDLER_H_
+#define CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_PAGE_ACTION_HANDLER_H_
#include <string>
@@ -13,15 +13,15 @@
namespace extensions {
-// Parses the "browser_action" manifest key.
-class BrowserActionHandler : public ManifestHandler {
+// Parses the "page_action" manifest key.
+class PageActionHandler : public ManifestHandler {
public:
- BrowserActionHandler();
- virtual ~BrowserActionHandler();
+ PageActionHandler();
+ virtual ~PageActionHandler();
virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
};
} // namespace extensions
-#endif // CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_BROWSER_ACTION_HANDLER_H_
+#endif // CHROME_COMMON_EXTENSIONS_API_EXTENSION_ACTION_PAGE_ACTION_HANDLER_H_

Powered by Google App Engine
This is Rietveld 408576698