Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2638)

Unified Diff: chrome/common/extensions/api/extension_action/action_info.h

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/extensions/api/extension_action/action_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/extension_action/action_info.h
diff --git a/chrome/common/extensions/api/extension_action/action_info.h b/chrome/common/extensions/api/extension_action/action_info.h
index 1f148ef2ebeede6e126f8218e315357f8389cdaa..7ce43fa6575a3e85095af086fcdde55a42224312 100644
--- a/chrome/common/extensions/api/extension_action/action_info.h
+++ b/chrome/common/extensions/api/extension_action/action_info.h
@@ -30,6 +30,9 @@ struct ActionInfo {
// Returns the extension's browser action, if any.
static const ActionInfo* GetBrowserActionInfo(const Extension* extension);
+ // Returns the extension's page action, if any.
+ static const ActionInfo* GetPageActionInfo(const Extension* extension);
+
// Returns the extension's script badge.
static const ActionInfo* GetScriptBadgeInfo(const Extension* etxension);
@@ -39,12 +42,19 @@ struct ActionInfo {
// Sets the extension's browser action. |extension| takes ownership of |info|.
static void SetBrowserActionInfo(Extension* extension, ActionInfo* info);
+ // Sets the extension's page action. |extension| takes ownership of |info|.
+ static void SetPageActionInfo(Extension* extension, ActionInfo* info);
+
// Sets the extension's script badge. |extension| takes ownership of |info|.
- static void SetScriptBadgeInfo(Extension* etxension, ActionInfo* info);
+ static void SetScriptBadgeInfo(Extension* extension, ActionInfo* info);
// Sets the extension's page launcher. |extension| takes ownership of |info|.
static void SetPageLauncherInfo(Extension* extension, ActionInfo* info);
+ // Returns true if the extension needs a verbose install message because
+ // of its page action.
+ static bool IsVerboseInstallMessage(const Extension* extension);
+
// Empty implies the key wasn't present.
ExtensionIconSet default_icon;
std::string default_title;
« no previous file with comments | « chrome/chrome_common.gypi ('k') | chrome/common/extensions/api/extension_action/action_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698