chrome/test/data/extensions/manifest_tests/page_action_manifest_version_2.json - Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/manifest_tests/page_action_manifest_version_2.json

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/extensions/page_actions_custom_bindings.cc ('k') | chrome/test/data/extensions/manifest_tests/page_action_manifest_version_2b.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/manifest_tests/page_action_manifest_version_2.json

diff --git a/chrome/test/data/extensions/manifest_tests/page_action_manifest_version_2.json b/chrome/test/data/extensions/manifest_tests/page_action_manifest_version_2.json

deleted file mode 100644

index b092b7fd99eb20c39ff195538a1545fb40857035..0000000000000000000000000000000000000000

--- a/chrome/test/data/extensions/manifest_tests/page_action_manifest_version_2.json

+++ /dev/null

@@ -1,14 +0,0 @@

- "manifest_version": 2,

- "name": "my extension",

- "version": "1.0.0.0",

- "description": "All these page action sub-features are removed in manifest version 2",

- "page_action": {

- "id": "id",

- "icons": [

- "pageAction.png"

- ],

- "name": "name",

- "popup": "popup.html"

- }