chrome/test/data/extensions/page_action/page_action_manifest_version_2b.json - Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/test/data/extensions/page_action/page_action_manifest_version_2b.json

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « chrome/test/data/extensions/page_action/page_action_manifest_version_2.json ('k') | chrome/utility/chrome_content_utility_client.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "manifest_version": 2,	2 "manifest_version": 2,

3 "name": "my extension",	3 "name": "my extension",

4 "version": "1.0.0.0",	4 "version": "1.0.0.0",

5 "description": "The page_action.popup value cannot be an object in manifest_ve rsion 2.",	5 "description": "The page_action.popup value cannot be an object in manifest_ve rsion 2.",

6 "page_action": {	6 "page_action": {

7 "default_popup": {	7 "default_popup": {

8 }	8 }

9 }	9 }

10 }	10 }

OLD	NEW