Move page action manifest parsing out of Extension; the first multi-key manifest handler.

chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
 
 #include "base/command_line.h"
-#include "base/files/scoped_temp_dir.h"
 #include "base/json/json_file_value_serializer.h"
+#include "base/memory/linked_ptr.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/extensions/extension_manifest_constants.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace errors = extension_manifest_errors;
 
 TEST_F(ExtensionManifestTest, PlatformApps) {
   scoped_refptr<extensions::Extension> extension =
       LoadAndExpectSuccess("init_valid_platform_app.json");
   EXPECT_TRUE(extension->is_storage_isolated());
@@ skipping 77 matching lines @@
     "serial",
   };
   // TODO(miket): When the first platform-app API leaves experimental, write
   // similar code that tests without the experimental flag.
 
   // This manifest is a skeleton used to build more specific manifests for
   // testing. The requirements are that (1) it be a valid platform app, and (2)
   // it contain no permissions dictionary.
   std::string error;
   scoped_ptr<DictionaryValue> manifest(
-      LoadManifestFile("init_valid_platform_app.json", &error));
+      LoadManifest("init_valid_platform_app.json", &error));
 
-  base::ScopedTempDir temp_dir;
-  ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
-
+  std::vector<linked_ptr<DictionaryValue> > manifests;
   // Create each manifest.
   for (size_t i = 0; i < arraysize(kPlatformAppExperimentalApis); ++i) {
     const char* api_name = kPlatformAppExperimentalApis[i];
 
     // DictionaryValue will take ownership of this ListValue.
     ListValue *permissions = new ListValue();
     permissions->Append(base::Value::CreateStringValue("experimental"));
     permissions->Append(base::Value::CreateStringValue(api_name));
     manifest->Set("permissions", permissions);
-
-    // Each of these files lives in the scoped temp directory, so it will be
-    // cleaned up at test teardown.
-    base::FilePath file_path = temp_dir.path().AppendASCII(api_name);
-    JSONFileValueSerializer serializer(file_path);
-    serializer.Serialize(*(manifest.get()));
+    manifests.push_back(make_linked_ptr(manifest->DeepCopy()));
   }
 
   // First try to load without any flags. This should fail for every API.
   for (size_t i = 0; i < arraysize(kPlatformAppExperimentalApis); ++i) {
-    const char* api_name = kPlatformAppExperimentalApis[i];
-    base::FilePath file_path = temp_dir.path().AppendASCII(api_name);
-    LoadAndExpectError(file_path.MaybeAsASCII().c_str(),
+    LoadAndExpectError(Manifest(manifests[i].get(), ""),
                        errors::kExperimentalFlagRequired);
   }
 
   // Now try again with the experimental flag set.
   CommandLine::ForCurrentProcess()->AppendSwitch(
       switches::kEnableExperimentalExtensionApis);
   for (size_t i = 0; i < arraysize(kPlatformAppExperimentalApis); ++i) {
-    const char* api_name = kPlatformAppExperimentalApis[i];
-    base::FilePath file_path = temp_dir.path().AppendASCII(api_name);
-    LoadAndExpectSuccess(file_path.MaybeAsASCII().c_str());
+    LoadAndExpectSuccess(Manifest(manifests[i].get(), ""));
   }
 }