Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Side by Side Diff: chrome/common/extensions/api/omnibox/omnibox_handler.h

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_API_OMNIBOX_OMNIBOX_HANDLER_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_API_OMNIBOX_OMNIBOX_HANDLER_H_
6 #define CHROME_COMMON_EXTENSIONS_API_OMNIBOX_OMNIBOX_HANDLER_H_ 6 #define CHROME_COMMON_EXTENSIONS_API_OMNIBOX_OMNIBOX_HANDLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "chrome/common/extensions/extension.h" 10 #include "chrome/common/extensions/extension.h"
11 #include "chrome/common/extensions/manifest_handler.h" 11 #include "chrome/common/extensions/manifest_handler.h"
12 12
13 namespace extensions { 13 namespace extensions {
14 14
15 class Extension; 15 class Extension;
16 16
17 struct OmniboxInfo : public Extension::ManifestData { 17 struct OmniboxInfo : public Extension::ManifestData {
18 // The Omnibox keyword for an extension. 18 // The Omnibox keyword for an extension.
19 std::string keyword; 19 std::string keyword;
20 20
21 // Returns the omnibox keyword for the extension. 21 // Returns the omnibox keyword for the extension.
22 static const std::string& GetKeyword(const Extension* extension); 22 static const std::string& GetKeyword(const Extension* extension);
23
24 // Returns true if the extension needs a verbose install message.
25 // TODO(yoz): This should be associated with page actions, not
26 // the omnibox.
27 static bool IsVerboseInstallMessage(const Extension* extension);
28 }; 23 };
29 24
30 // Parses the "omnibox" manifest key. 25 // Parses the "omnibox" manifest key.
31 class OmniboxHandler : public ManifestHandler { 26 class OmniboxHandler : public ManifestHandler {
32 public: 27 public:
33 OmniboxHandler(); 28 OmniboxHandler();
34 virtual ~OmniboxHandler(); 29 virtual ~OmniboxHandler();
35 30
36 virtual bool Parse(Extension* extension, string16* error) OVERRIDE; 31 virtual bool Parse(Extension* extension, string16* error) OVERRIDE;
37 }; 32 };
38 33
39 } // namespace extensions 34 } // namespace extensions
40 35
41 #endif // CHROME_COMMON_EXTENSIONS_API_OMNIBOX_OMNIBOX_HANDLER_H_ 36 #endif // CHROME_COMMON_EXTENSIONS_API_OMNIBOX_OMNIBOX_HANDLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698