Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Side by Side Diff: chrome/browser/extensions/api/extension_action/extension_action_api.cc

Issue 12042096: Move page action manifest parsing out of Extension; the first multi-key manifest handler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_action_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h" 5 #include "chrome/browser/extensions/api/extension_action/extension_action_api.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/base64.h" 9 #include "base/base64.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
11 #include "base/string_util.h" 11 #include "base/string_util.h"
12 #include "base/strings/string_number_conversions.h" 12 #include "base/strings/string_number_conversions.h"
13 #include "base/values.h" 13 #include "base/values.h"
14 #include "chrome/browser/extensions/api/extension_action/extension_page_actions_ api_constants.h" 14 #include "chrome/browser/extensions/api/extension_action/extension_page_actions_ api_constants.h"
15 #include "chrome/browser/extensions/extension_action.h" 15 #include "chrome/browser/extensions/extension_action.h"
16 #include "chrome/browser/extensions/extension_action_manager.h" 16 #include "chrome/browser/extensions/extension_action_manager.h"
17 #include "chrome/browser/extensions/extension_function_registry.h" 17 #include "chrome/browser/extensions/extension_function_registry.h"
18 #include "chrome/browser/extensions/extension_service.h" 18 #include "chrome/browser/extensions/extension_service.h"
19 #include "chrome/browser/extensions/extension_system.h" 19 #include "chrome/browser/extensions/extension_system.h"
20 #include "chrome/browser/extensions/extension_tab_util.h" 20 #include "chrome/browser/extensions/extension_tab_util.h"
21 #include "chrome/browser/extensions/location_bar_controller.h" 21 #include "chrome/browser/extensions/location_bar_controller.h"
22 #include "chrome/browser/extensions/state_store.h" 22 #include "chrome/browser/extensions/state_store.h"
23 #include "chrome/browser/extensions/tab_helper.h" 23 #include "chrome/browser/extensions/tab_helper.h"
24 #include "chrome/browser/profiles/profile.h" 24 #include "chrome/browser/profiles/profile.h"
25 #include "chrome/common/chrome_notification_types.h" 25 #include "chrome/common/chrome_notification_types.h"
26 #include "chrome/common/extensions/api/extension_action/action_info.h" 26 #include "chrome/common/extensions/api/extension_action/action_info.h"
27 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h " 27 #include "chrome/common/extensions/api/extension_action/browser_action_handler.h "
28 #include "chrome/common/extensions/api/extension_action/page_action_handler.h"
28 #include "chrome/common/extensions/api/extension_action/script_badge_handler.h" 29 #include "chrome/common/extensions/api/extension_action/script_badge_handler.h"
29 #include "chrome/common/extensions/extension_manifest_constants.h" 30 #include "chrome/common/extensions/extension_manifest_constants.h"
30 #include "chrome/common/extensions/manifest_handler.h" 31 #include "chrome/common/extensions/manifest_handler.h"
31 #include "chrome/common/render_messages.h" 32 #include "chrome/common/render_messages.h"
32 #include "content/public/browser/navigation_entry.h" 33 #include "content/public/browser/navigation_entry.h"
33 #include "content/public/browser/notification_service.h" 34 #include "content/public/browser/notification_service.h"
34 #include "extensions/common/error_utils.h" 35 #include "extensions/common/error_utils.h"
35 #include "ui/gfx/image/image_skia.h" 36 #include "ui/gfx/image/image_skia.h"
36 37
37 namespace extensions { 38 namespace extensions {
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 // 184 //
184 // ExtensionActionAPI 185 // ExtensionActionAPI
185 // 186 //
186 187
187 static base::LazyInstance<ProfileKeyedAPIFactory<ExtensionActionAPI> > 188 static base::LazyInstance<ProfileKeyedAPIFactory<ExtensionActionAPI> >
188 g_factory = LAZY_INSTANCE_INITIALIZER; 189 g_factory = LAZY_INSTANCE_INITIALIZER;
189 190
190 ExtensionActionAPI::ExtensionActionAPI(Profile* profile) { 191 ExtensionActionAPI::ExtensionActionAPI(Profile* profile) {
191 ManifestHandler::Register(extension_manifest_keys::kBrowserAction, 192 ManifestHandler::Register(extension_manifest_keys::kBrowserAction,
192 make_linked_ptr(new BrowserActionHandler)); 193 make_linked_ptr(new BrowserActionHandler));
194 linked_ptr<PageActionHandler> page_action_handler(new PageActionHandler);
195 ManifestHandler::Register(
196 extension_manifest_keys::kPageAction, page_action_handler);
197 ManifestHandler::Register(
198 extension_manifest_keys::kPageActions, page_action_handler);
193 ManifestHandler::Register(extension_manifest_keys::kScriptBadge, 199 ManifestHandler::Register(extension_manifest_keys::kScriptBadge,
194 make_linked_ptr(new ScriptBadgeHandler)); 200 make_linked_ptr(new ScriptBadgeHandler));
195 201
196 ExtensionFunctionRegistry* registry = 202 ExtensionFunctionRegistry* registry =
197 ExtensionFunctionRegistry::GetInstance(); 203 ExtensionFunctionRegistry::GetInstance();
198 204
199 // Browser Actions 205 // Browser Actions
200 registry->RegisterFunction<BrowserActionSetIconFunction>(); 206 registry->RegisterFunction<BrowserActionSetIconFunction>();
201 registry->RegisterFunction<BrowserActionSetTitleFunction>(); 207 registry->RegisterFunction<BrowserActionSetTitleFunction>();
202 registry->RegisterFunction<BrowserActionSetBadgeTextFunction>(); 208 registry->RegisterFunction<BrowserActionSetBadgeTextFunction>();
(...skipping 525 matching lines...) Expand 10 before | Expand all | Expand 10 after
728 return true; 734 return true;
729 } 735 }
730 736
731 bool EnablePageActionsFunction::RunImpl() { 737 bool EnablePageActionsFunction::RunImpl() {
732 return SetPageActionEnabled(true); 738 return SetPageActionEnabled(true);
733 } 739 }
734 740
735 bool DisablePageActionsFunction::RunImpl() { 741 bool DisablePageActionsFunction::RunImpl() {
736 return SetPageActionEnabled(false); 742 return SetPageActionEnabled(false);
737 } 743 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_action_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698