gsdl - Issue 12042069: Scripts to download files from google storage based on sha1 sums

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: gsdl

Issue 12042069: Scripts to download files from google storage based on sha1 sums (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Review fixes, updated gsutil Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/usr/bin/env bash	1 #!/usr/bin/env bash

2 # Copyright (c) 2009 The Chromium Authors. All rights reserved.	2 # Copyright (c) 2009 The Chromium Authors. All rights reserved.

3 # Use of this source code is governed by a BSD-style license that can be	3 # Use of this source code is governed by a BSD-style license that can be

4 # found in the LICENSE file.	4 # found in the LICENSE file.

5	5

6 base_dir=$(dirname "$0")	6 base_dir=$(dirname "$0")

7	7

8 PYTHONDONTWRITEBYTECODE=1 exec python "$base_dir/gcl.py" "$@"	8 PYTHONDONTWRITEBYTECODE=1 exec python "$base_dir/download_from_google_storage.py " "$@"
	M-A Ruel 2013/02/25 15:15:06 Are these needed? The question is: does devs will Are these needed? The question is: does devs will use them at the command line? If not, it's probably better to not include these wrappers. Ryan Tseng 2013/02/27 02:06:56 I added these in per xusydoc@'s suggestion. downlo Show quoted text On 2013/02/25 15:15:06, Marc-Antoine Ruel wrote: > Are these needed? The question is: does devs will use them at the command line? > If not, it's probably better to not include these wrappers. I added these in per xusydoc@'s suggestion. download_from_google_storage is mean to be used within a DEPS file or in submodules as a post checkout hook. upload_to_google_storage is mean to be called by the dev manually. I could leave gsul in and remove gsdl, but then it'll feel lopsided. M-A Ruel 2013/02/27 21:52:07 Then I prefer neither. I don't think it's the kind Show quoted text On 2013/02/27 02:06:56, Ryan T. wrote: > On 2013/02/25 15:15:06, Marc-Antoine Ruel wrote: > > Are these needed? The question is: does devs will use them at the command > line? > > If not, it's probably better to not include these wrappers. > > I added these in per xusydoc@'s suggestion. > download_from_google_storage is mean to be used within a DEPS file or in > submodules as a post checkout hook. > upload_to_google_storage is mean to be called by the dev manually. > > I could leave gsul in and remove gsdl, but then it'll feel lopsided. Then I prefer neither. I don't think it's the kind of tool used enough to warrant a wrapper. Wrappers can be added later if wanted.
OLD	NEW

« download_from_google_storage.py ('K') | « download_from_google_storage.py ('k') | gsdl.bat » ('j') | third_party/gsutil/README » ('J')