Initial revision of ARM simulator and (empty) MIPS simulator.

runtime/vm/isolate.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/isolate.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "lib/mirrors.h"
 #include "vm/code_observers.h"
 #include "vm/compiler_stats.h"
 #include "vm/dart_api_state.h"
 #include "vm/dart_entry.h"
 #include "vm/debugger.h"
 #include "vm/heap.h"
 #include "vm/message_handler.h"
 #include "vm/object_store.h"
 #include "vm/parser.h"
 #include "vm/port.h"
+#include "vm/simulator.h"
 #include "vm/stack_frame.h"
 #include "vm/stub_code.h"
 #include "vm/symbols.h"
 #include "vm/thread.h"
 #include "vm/timer.h"
 #include "vm/visitor.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, report_usage_count, false,
@@ skipping 233 matching lines @@
       main_port_(0),
       heap_(NULL),
       object_store_(NULL),
       top_context_(Context::null()),
       top_exit_frame_info_(0),
       init_callback_data_(NULL),
       library_tag_handler_(NULL),
       api_state_(NULL),
       stub_code_(NULL),
       debugger_(NULL),
+      simulator_(NULL),
       long_jump_base_(NULL),
       timer_list_(),
       deopt_id_(0),
       ic_data_array_(Array::null()),
       mutex_(new Mutex()),
       stack_limit_(0),
       saved_stack_limit_(0),
       message_handler_(NULL),
       spawn_data_(0),
       gc_prologue_callbacks_(),
       gc_epilogue_callbacks_(),
       deopt_cpu_registers_copy_(NULL),
       deopt_fpu_registers_copy_(NULL),
       deopt_frame_copy_(NULL),
       deopt_frame_copy_size_(0),
       deferred_doubles_(NULL),
       deferred_mints_(NULL) {
 }
 
 
 Isolate::~Isolate() {
   delete [] name_;
   delete heap_;
   delete object_store_;
   delete api_state_;
   delete stub_code_;
   delete debugger_;
+#if defined(USING_SIMULATOR)
+  delete simulator_;
+#endif

[siva, 2013/01/24 02:03:09]

Is the #if defined(USING_SIMULATOR) necessary here?

[regis, 2013/01/24 21:47:48]

We would need to declare a dummy empty Simulator class for ia32 and x64,
otherwise, without the if-def, we get a warning (=error) that no destructor or
delete operator will be called, even if the forwarded declared class Simulator
is defined (it is not defined).

   delete mutex_;
   mutex_ = NULL;  // Fail fast if interrupts are scheduled on a dead isolate.
   delete message_handler_;
   message_handler_ = NULL;  // Fail fast if we send messages to a dead isolate.
 }
 
 void Isolate::SetCurrent(Isolate* current) {
   Thread::SetThreadLocal(isolate_key, reinterpret_cast<uword>(current));
 }
 
@@ skipping 39 matching lines @@
   result->set_main_port(PortMap::CreatePort(result->message_handler()));
   result->BuildName(name_prefix);
 
   result->debugger_ = new Debugger();
   result->debugger_->Initialize(result);
   if (FLAG_trace_isolates) {
     if (name_prefix == NULL || strcmp(name_prefix, "vm-isolate") != 0) {
       OS::Print("[+] Starting isolate:\n"
                 "\tisolate:    %s\n", result->name());
     }
   }

[siva, 2013/01/24 02:03:09]

Shouldn't we be creating a simulator here and assign it to
the isolate?

[regis, 2013/01/24 21:47:48]

We create the simulator on demand, when it is accessed for the first time. See
Simulator::Current(). Is there any benefit of doing it here? Either way is fine
with me.

   return result;
 }
 
 
 void Isolate::BuildName(const char* name_prefix) {
   ASSERT(name_ == NULL);
   if (name_prefix == NULL) {
     name_prefix = "isolate";
   }
   const char* kFormat = "%s-%lld";
@@ skipping 246 matching lines @@
 
 
 void Isolate::VisitWeakPersistentHandles(HandleVisitor* visitor,
                                          bool visit_prologue_weak_handles) {
   if (api_state() != NULL) {
     api_state()->VisitWeakHandles(visitor, visit_prologue_weak_handles);
   }
 }
 
 }  // namespace dart