Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12041029: Add ResetModem method and call it once non_cellular activation is done. (Closed)

Created:
7 years, 11 months ago by rkc
Modified:
7 years, 11 months ago
Reviewers:
stevenjb, Ben Chan
CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add ResetModem method and call it once non_cellular activation is done. Once non_cellular activation is done, the modem needs to be reset to get into the new activated state. R=stevenjb@chromium.org,benchan@chromium.org BUG=171535 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178823

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M chrome/browser/chromeos/cros/mock_network_library.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_base.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_cros.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_stub.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/cros/network_library_impl_stub.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/mobile/mobile_activator.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chromeos/dbus/mock_shill_device_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_device_client.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_device_client.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_device_client_unittest.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M chromeos/network/cros_network_functions.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/network/cros_network_functions.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
rkc
7 years, 11 months ago (2013-01-22 22:48:47 UTC) #1
Ben Chan
On 2013/01/22 22:48:47, Rahul Chaturvedi wrote:
7 years, 11 months ago (2013-01-23 19:28:09 UTC) #2
Ben Chan
https://codereview.chromium.org/12041029/diff/1/chrome/browser/chromeos/cros/network_library_impl_cros.cc File chrome/browser/chromeos/cros/network_library_impl_cros.cc (right): https://codereview.chromium.org/12041029/diff/1/chrome/browser/chromeos/cros/network_library_impl_cros.cc#newcode445 chrome/browser/chromeos/cros/network_library_impl_cros.cc:445: NOTREACHED() << "Calling SetCarrier method w/o cellular device."; SetCarrier ...
7 years, 11 months ago (2013-01-23 19:28:13 UTC) #3
Ben Chan
https://codereview.chromium.org/12041029/diff/1/chromeos/dbus/shill_device_client.cc File chromeos/dbus/shill_device_client.cc (right): https://codereview.chromium.org/12041029/diff/1/chromeos/dbus/shill_device_client.cc#newcode185 chromeos/dbus/shill_device_client.cc:185: shill::kResetFunction); shill::kResetFunction is not defined.
7 years, 11 months ago (2013-01-23 19:57:20 UTC) #4
Ben Chan
https://codereview.chromium.org/12041029/diff/1/chromeos/dbus/shill_device_client.cc File chromeos/dbus/shill_device_client.cc (right): https://codereview.chromium.org/12041029/diff/1/chromeos/dbus/shill_device_client.cc#newcode185 chromeos/dbus/shill_device_client.cc:185: shill::kResetFunction); On 2013/01/23 19:57:20, Ben Chan wrote: > shill::kResetFunction ...
7 years, 11 months ago (2013-01-23 20:19:48 UTC) #5
stevenjb
lgtm
7 years, 11 months ago (2013-01-23 21:41:52 UTC) #6
rkc
https://codereview.chromium.org/12041029/diff/1/chrome/browser/chromeos/cros/network_library_impl_cros.cc File chrome/browser/chromeos/cros/network_library_impl_cros.cc (right): https://codereview.chromium.org/12041029/diff/1/chrome/browser/chromeos/cros/network_library_impl_cros.cc#newcode445 chrome/browser/chromeos/cros/network_library_impl_cros.cc:445: NOTREACHED() << "Calling SetCarrier method w/o cellular device."; On ...
7 years, 11 months ago (2013-01-25 10:49:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/12041029/7001
7 years, 11 months ago (2013-01-25 10:50:11 UTC) #8
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 15:39:55 UTC) #9
Message was sent while issue was closed. 
Change committed as 178823

Powered by Google App Engine
This is Rietveld 408576698