Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 12041012: cc: Chromium-stylify the DelegatedRendererLayer classes and tests. (Closed)

Created:
7 years, 11 months ago by danakj
Modified:
7 years, 11 months ago
Reviewers:
jamesr, piman
CC:
chromium-reviews, cc-bugs_chromium.org, backer
Visibility:
Public.

Description

cc: Chromium-stylify the DelegatedRendererLayer classes and tests. No change in behaviour, style change only. Depends on: https://codereview.chromium.org/12040011 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178226

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1363 lines, -1163 lines) Patch
M cc/delegated_renderer_layer.h View 1 chunk +8 lines, -7 lines 0 comments Download
M cc/delegated_renderer_layer.cc View 1 chunk +11 lines, -13 lines 0 comments Download
M cc/delegated_renderer_layer_impl.h View 1 chunk +47 lines, -36 lines 0 comments Download
M cc/delegated_renderer_layer_impl.cc View 1 2 3 1 chunk +175 lines, -150 lines 0 comments Download
M cc/delegated_renderer_layer_impl_unittest.cc View 1 2 1 chunk +1119 lines, -954 lines 0 comments Download
M cc/layer_tree_host_unittest_context.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/render_surface_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
danakj
7 years, 11 months ago (2013-01-22 01:42:17 UTC) #1
piman
LGTM+nit https://codereview.chromium.org/12041012/diff/3008/cc/delegated_renderer_layer_impl.cc File cc/delegated_renderer_layer_impl.cc (right): https://codereview.chromium.org/12041012/diff/3008/cc/delegated_renderer_layer_impl.cc#newcode204 cc/delegated_renderer_layer_impl.cc:204: else { nit: need brackets around first clause ...
7 years, 11 months ago (2013-01-22 18:52:23 UTC) #2
danakj
https://codereview.chromium.org/12041012/diff/3008/cc/delegated_renderer_layer_impl.cc File cc/delegated_renderer_layer_impl.cc (right): https://codereview.chromium.org/12041012/diff/3008/cc/delegated_renderer_layer_impl.cc#newcode204 cc/delegated_renderer_layer_impl.cc:204: else { On 2013/01/22 18:52:23, piman wrote: > nit: ...
7 years, 11 months ago (2013-01-22 19:00:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12041012/6001
7 years, 11 months ago (2013-01-22 23:06:26 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=102194
7 years, 11 months ago (2013-01-23 01:30:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/12041012/6001
7 years, 11 months ago (2013-01-23 02:08:52 UTC) #6
commit-bot: I haz the power
7 years, 11 months ago (2013-01-23 03:22:29 UTC) #7
Message was sent while issue was closed.
Change committed as 178226

Powered by Google App Engine
This is Rietveld 408576698