Introduce empty IBusDaemonController class.

Introduce empty IBusDaemonController class.

This class is substitue of IBusController.

BUG=170671
TEST=None


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=179570

[satorux1, 2013-01-22 07:06:01]

https://codereview.chromium.org/12041006/diff/1/chromeos/ime/ibus_daemon_cont...
File chromeos/ime/ibus_daemon_controller.cc (right):

https://codereview.chromium.org/12041006/diff/1/chromeos/ime/ibus_daemon_cont...
chromeos/ime/ibus_daemon_controller.cc:16: class IBusDaemonControllerImpl :
public IBusDaemonController {
This class should be used from a single thread, right? You could use
ThreadChecker in base/threading.

[Seigo Nonaka, 2013-01-22 10:53:48]

https://codereview.chromium.org/12041006/diff/1/chromeos/ime/ibus_daemon_cont...
File chromeos/ime/ibus_daemon_controller.cc (right):

https://codereview.chromium.org/12041006/diff/1/chromeos/ime/ibus_daemon_cont...
chromeos/ime/ibus_daemon_controller.cc:16: class IBusDaemonControllerImpl :
public IBusDaemonController {
Right, use NonThreadSafe for thread checking.
On 2013/01/22 07:06:01, satorux1 wrote:
> This class should be used from a single thread, right? You could use
> ThreadChecker in base/threading.

[satorux1, 2013-01-22 17:09:52]

https://codereview.chromium.org/12041006/diff/1/chromeos/ime/ibus_daemon_cont...
File chromeos/ime/ibus_daemon_controller.cc (right):

https://codereview.chromium.org/12041006/diff/1/chromeos/ime/ibus_daemon_cont...
chromeos/ime/ibus_daemon_controller.cc:16: class IBusDaemonControllerImpl :
public IBusDaemonController {
On 2013/01/22 10:53:48, Seigo Nonaka wrote:
> Right, use NonThreadSafe for thread checking.
> On 2013/01/22 07:06:01, satorux1 wrote:
> > This class should be used from a single thread, right? You could use
> > ThreadChecker in base/threading.
> 

I'd suggest to use ThreadChecker. non_thread_safe.h says:

// Note that base::ThreadChecker offers identical functionality to              
         
// NonThreadSafe, but does not require inheritence. In general, it is preferable
         
// to have a base::ThreadChecker as a member, rather than inherit from          
         
// NonThreadSafe. For more details about when to choose one over the other, see 
         
// the documentation for base::ThreadChecker.                                   
         


In general, composition is more preferable than inheritance. Inheritance is
harder to follow.

[Seigo Nonaka, 2013-01-23 08:06:08]

https://codereview.chromium.org/12041006/diff/1/chromeos/ime/ibus_daemon_cont...
File chromeos/ime/ibus_daemon_controller.cc (right):

https://codereview.chromium.org/12041006/diff/1/chromeos/ime/ibus_daemon_cont...
chromeos/ime/ibus_daemon_controller.cc:16: class IBusDaemonControllerImpl :
public IBusDaemonController {
On 2013/01/22 17:09:52, satorux1 wrote:
> On 2013/01/22 10:53:48, Seigo Nonaka wrote:
> > Right, use NonThreadSafe for thread checking.
> > On 2013/01/22 07:06:01, satorux1 wrote:
> > > This class should be used from a single thread, right? You could use
> > > ThreadChecker in base/threading.
> > 
> 
> I'd suggest to use ThreadChecker. non_thread_safe.h says:
> 
> // Note that base::ThreadChecker offers identical functionality to            
 
>          
> // NonThreadSafe, but does not require inheritence. In general, it is
preferable
>          
> // to have a base::ThreadChecker as a member, rather than inherit from        
 
>          
> // NonThreadSafe. For more details about when to choose one over the other,
see 
>          
> // the documentation for base::ThreadChecker.                                 
 
>          
> 
> 
> In general, composition is more preferable than inheritance. Inheritance is
> harder to follow.

Sorry I missed NonThreadSafe comment.
Updated patch to use ThreadChecker.
Thank you!

[satorux1, 2013-01-29 05:10:00]

LGTM

[commit-bot: I haz the power, 2013-01-30 06:15:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/nona@chromium.org/12041006/9001

[commit-bot: I haz the power, 2013-01-30 09:14:46]

Change committed as 179570