Issue 12040052: Fix bug in edge case in populating PointerMaps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12040052: Fix bug in edge case in populating PointerMaps (Closed)

Created:
7 years, 11 months ago by danno

Modified:
7 years, 11 months ago

Reviewers:
Vyacheslav Egorov (Chromium), Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix bug in edge case in populating PointerMaps If a live range was split immediately before an instruction that required a safe-point pointer map, it was possible for the safe-point to incorrectly use the register/stack slot information of the preceeding live range rather than the one that actually covers the safe-point. R=mstarzinger@chromium.org,vegorov@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=13493

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/lithium-allocator.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

LGTM. Do we have a regression test for that?

Expand Messages | Collapse Messages