Issue 12040046: Correctly forward error code when git pull fails in crup-runner.sh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12040046: Correctly forward error code when git pull fails in crup-runner.sh (Closed)

Created:
7 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
7 years, 11 months ago

Reviewers:
szager1

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Visibility:
Public.

More Reviews

Description

Correctly forward error code when git pull fails in crup-runner.sh The old code would always exit 0, because it returned the exit status of the if command BUG=none TEST=try to run git crup in src/ with unstaged changes. Should bail out and not run hooks R=szager@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=178356

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	crup-runner.sh	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/12040046/1

7 years, 11 months ago (2013-01-23 19:56:31 UTC) #3

Message was sent while issue was closed.

Change committed as 178356

Expand Messages | Collapse Messages