src/stub-cache.cc - Issue 12040039: Always fail when trying to store to an undeclared global variable, even if it was found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/stub-cache.cc

Issue 12040039: Always fail when trying to store to an undeclared global variable, even if it was found. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Fix test to check for the exact reference error. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/stub-cache.cc

diff --git a/src/stub-cache.cc b/src/stub-cache.cc

index 73272a250e426109de3eccf3c45cb0a95245c0db..43d0ab94eb68dbccb07093c471252df58410b657 100644

--- a/src/stub-cache.cc

+++ b/src/stub-cache.cc

@@ -1071,7 +1071,7 @@ static MaybeObject* ThrowReferenceError(String* name) {

// can't use either LoadIC or KeyedLoadIC constructors.

IC ic(IC::NO_EXTRA_FRAME, Isolate::Current());

ASSERT(ic.target()->is_load_stub() || ic.target()->is_keyed_load_stub());

- if (!ic.SlowIsContextual()) return HEAP->undefined_value();

+ if (!ic.SlowIsUndeclaredGlobal()) return HEAP->undefined_value();

// Throw a reference error.

HandleScope scope;

« no previous file with comments | « src/ic.cc ('k') | test/cctest/cctest.gyp » ('j') | no next file with comments »