Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 12039038: Enable Latin-1 (Closed)

Created:
7 years, 11 months ago by drcarney
Modified:
7 years, 10 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : simplified implementation #

Patch Set 3 : forgot something #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M build/common.gypi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/v8.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/string.js View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
LGTM. Waiting for landing.
7 years, 11 months ago (2013-01-23 14:07:11 UTC) #1
drcarney
I forgot a tiny change in string.js Also, I'm now using the preprocessor variable in ...
7 years, 10 months ago (2013-02-04 10:02:37 UTC) #2
Yang
On 2013/02/04 10:02:37, dcarney wrote: > I forgot a tiny change in string.js > Also, ...
7 years, 10 months ago (2013-02-04 10:03:51 UTC) #3
Yang
7 years, 10 months ago (2013-02-18 10:27:54 UTC) #4
Message was sent while issue was closed.
Committed manually as r13682 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698