Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 12039033: DBus: Fixes a flaky test case. (Closed)

Created:
7 years, 11 months ago by deymo
Modified:
7 years, 11 months ago
Reviewers:
keybuk, stevenjb, satorux1
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

DBus: Fixes a flaky test case. In the UnregisterExportedObject test, an ExportedObject is created, destroyed and created again as a new object. The test assumes the new object is different from the first one just comparing the memory pointers to those objects. Nevertheless, the memory manager could possibly alloc the same memory address for the second object since the first one was already destroyed. This fixes this situation preventing the first object from being destroyed incrementing its reference count. BUG=chromium:137846 TEST=test enabled. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178450

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M dbus/bus_unittest.cc View 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
deymo
Isn't it great when you first have a fix and suddenly you find a bug ...
7 years, 11 months ago (2013-01-23 05:07:04 UTC) #1
keybuk
lgtm
7 years, 11 months ago (2013-01-23 19:00:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/deymo@chromium.org/12039033/1
7 years, 11 months ago (2013-01-23 22:25:15 UTC) #3
commit-bot: I haz the power
7 years, 11 months ago (2013-01-24 00:58:36 UTC) #4
Message was sent while issue was closed.
Change committed as 178450

Powered by Google App Engine
This is Rietveld 408576698