Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Side by Side Diff: content/common/gpu/image_transport_surface_android.cc

Issue 12038095: Android webview fix gpu crashes after destroy (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Style fixes. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/common/gpu/gpu_surface_lookup.h ('k') | ui/gl/gl_context.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/gpu/image_transport_surface.h" 5 #include "content/common/gpu/image_transport_surface.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "content/common/gpu/gpu_surface_lookup.h" 8 #include "content/common/gpu/gpu_surface_lookup.h"
9 #include "content/common/gpu/texture_image_transport_surface.h" 9 #include "content/common/gpu/texture_image_transport_surface.h"
10 #include "ui/gl/gl_surface_egl.h" 10 #include "ui/gl/gl_surface_egl.h"
11 11
12 namespace content { 12 namespace content {
13 13
14 // static 14 // static
15 scoped_refptr<gfx::GLSurface> ImageTransportSurface::CreateSurface( 15 scoped_refptr<gfx::GLSurface> ImageTransportSurface::CreateSurface(
16 GpuChannelManager* manager, 16 GpuChannelManager* manager,
17 GpuCommandBufferStub* stub, 17 GpuCommandBufferStub* stub,
18 const gfx::GLSurfaceHandle& handle) { 18 const gfx::GLSurfaceHandle& handle) {
19 scoped_refptr<gfx::GLSurface> surface; 19 scoped_refptr<gfx::GLSurface> surface;
20 if (!handle.handle && handle.transport) { 20 if (!handle.handle && handle.transport) {
21 surface = new TextureImageTransportSurface(manager, stub, handle); 21 surface = new TextureImageTransportSurface(manager, stub, handle);
22 } else if (handle.handle == gfx::kDummyPluginWindow && !handle.transport) { 22 } else if (handle.handle == gfx::kDummyPluginWindow && !handle.transport) {
23 DCHECK(GpuSurfaceLookup::GetInstance()); 23 DCHECK(GpuSurfaceLookup::GetInstance());
24 ANativeWindow* window = GpuSurfaceLookup::GetInstance()->GetNativeWidget( 24 ANativeWindow* window =
25 stub->surface_id()); 25 GpuSurfaceLookup::GetInstance()->AcquireNativeWidget(
26 DCHECK(window); 26 stub->surface_id());
27 surface = new gfx::NativeViewGLSurfaceEGL(false, window); 27 surface = new gfx::NativeViewGLSurfaceEGL(false, window);
28 if (!surface.get() || !surface->Initialize()) 28 bool initialize_success = surface->Initialize();
29 if (window)
30 ANativeWindow_release(window);
31 if (!initialize_success)
29 return NULL; 32 return NULL;
30 33
31 surface = new PassThroughImageTransportSurface( 34 surface = new PassThroughImageTransportSurface(
32 manager, stub, surface.get(), handle.transport); 35 manager, stub, surface.get(), handle.transport);
33 } else { 36 } else {
34 NOTIMPLEMENTED(); 37 NOTIMPLEMENTED();
35 return NULL; 38 return NULL;
36 } 39 }
37 40
38 if (surface->Initialize()) 41 if (surface->Initialize()) {
39 return surface; 42 return surface;
40 else { 43 } else {
41 LOG(ERROR) << "Failed to initialize ImageTransportSurface"; 44 LOG(ERROR) << "Failed to initialize ImageTransportSurface";
42 return NULL; 45 return NULL;
43 } 46 }
44 } 47 }
45 48
46 } // namespace content 49 } // namespace content
OLDNEW
« no previous file with comments | « content/common/gpu/gpu_surface_lookup.h ('k') | ui/gl/gl_context.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698