Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 12038037: Replace the misspelled range within a selection to correct spelling. (Closed)

Created:
7 years, 11 months ago by please use gerrit instead
Modified:
7 years, 10 months ago
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, rpetterson, rouslan+spellwatch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, groby+spellwatch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Replace the misspelled range within a selection to correct spelling. This CL changes the spell check correction to replace the misspelled range within a selection instead of replacing the whole selection. This change enables spell check of words selected with surrounding whitespace or punctuation. Such selection happens on a double-click of a word with a trailing underscore in Windows, for example. This CL requires the change in https://webkit.org/b/108513. BUG=167485, 169659 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=181968

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -2 lines) Patch
M chrome/browser/tab_contents/spelling_menu_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/render_view_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_view_impl.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
please use gerrit instead
Groby: PTAL. This CL switches misspelling replacement from frame->replaceRange() to frame->replaceMisspelledRange().
7 years, 10 months ago (2013-02-11 21:18:27 UTC) #1
please use gerrit instead
John: PTAL. I am asking for your review because I am adding a new interface ...
7 years, 10 months ago (2013-02-11 21:25:19 UTC) #2
please use gerrit instead
Thomas: PTAL. I am adding a new IPC message ViewMsg_ReplaceMisspelling, which Chrome is going to ...
7 years, 10 months ago (2013-02-11 21:29:00 UTC) #3
groby-ooo-7-16
Spelling LGTM. Wondering if we should instead use a single message with an enum indicating ...
7 years, 10 months ago (2013-02-11 21:30:50 UTC) #4
Tom Sepez
Messages LGTM. > Wondering if we should instead use a single message with an enum ...
7 years, 10 months ago (2013-02-11 21:36:37 UTC) #5
please use gerrit instead
John: Would you mind reviewing all of the changes in this CL?
7 years, 10 months ago (2013-02-11 21:47:45 UTC) #6
jam
On 2013/02/11 21:47:45, Rouslan Solomakhin wrote: > John: Would you mind reviewing all of the ...
7 years, 10 months ago (2013-02-11 22:11:00 UTC) #7
please use gerrit instead
Will submit to CQ tomorrow after webkit dependencies have been rolled past http://svn.webkit.org/repository/webkit/trunk@142494.
7 years, 10 months ago (2013-02-11 22:30:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/12038037/2001
7 years, 10 months ago (2013-02-12 16:37:03 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=98830
7 years, 10 months ago (2013-02-12 17:47:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rouslan@chromium.org/12038037/2001
7 years, 10 months ago (2013-02-12 18:04:29 UTC) #11
commit-bot: I haz the power
7 years, 10 months ago (2013-02-12 19:16:53 UTC) #12
Message was sent while issue was closed.
Change committed as 181968

Powered by Google App Engine
This is Rietveld 408576698