Issue 12038012: Merge Load from Keyed|Named load code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12038012: Merge Load from Keyed|Named load code. (Closed)

Created:
7 years, 11 months ago by Toon Verwaest

Modified:
7 years, 11 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Merge Load from Keyed|Named load code. Committed: https://code.google.com/p/v8/source/detail?r=13460

Patch Set 1 #

Total comments: 1

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -112 lines)			Patch
	M	src/ic.h	View		7 chunks	+27 lines, -22 lines	0 comments	Download
	M	src/ic.cc	View		9 chunks	+29 lines, -90 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

7 years, 11 months ago (2013-01-22 09:24:39 UTC) #2

lgtm

https://chromiumcodereview.appspot.com/12038012/diff/1/src/ic.cc
File src/ic.cc (left):

https://chromiumcodereview.appspot.com/12038012/diff/1/src/ic.cc#oldcode942
src/ic.cc:942: if (name->AsArrayIndex(&index)) return object->GetElement(index);
Per offline discussion: it seems this condition can never be true anyway, so
this line has been removed from the refactored version.

Expand Messages | Collapse Messages