Issue 12036063: Synchronize android test server internal maps

Issue 12036063: Synchronize android test server internal maps (Closed)

Created:
7 years, 11 months ago by boliu

Modified:
7 years, 11 months ago

Reviewers:
Yaron, Philippe, John Knottenbelt

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, ppi, digit1

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Synchronize android test server internal maps Count, request, and response maps are modified on two different threads in tests are possibly causing some tests to be flaky. So add synchronization. BUG=171765 Android only change. Ran through android bots. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178601

Patch Set 1 #

Patch Set 2 : fix find bugs #

Patch Set 3 : Fix the problem found by findbugs (no more presubmit error) #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -21 lines)			Patch
	M	build/android/findbugs_filter/findbugs_known_bugs.txt	View	1 2	1 chunk	+0 lines, -1 line	0 comments	Download
	M	net/test/android/javatests/src/org/chromium/net/test/util/TestWebServer.java	View	1 2	7 chunks	+41 lines, -20 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Philippe

Thanks Bo for fixing this, LGTM. My 2 cents: This looks correct to me now ...

7 years, 11 months ago (2013-01-24 15:18:59 UTC) #2

boliu

On 2013/01/24 15:18:59, Philippe wrote: > Thanks Bo for fixing this, LGTM. > > My ...

7 years, 11 months ago (2013-01-24 16:42:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/12036063/7001

7 years, 11 months ago (2013-01-24 17:37:18 UTC) #4

Message was sent while issue was closed.

Change committed as 178601

Expand Messages | Collapse Messages