Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 12036030: MIPS: Make HCheckPrototypeMaps compatible with parallel recompilation. (Closed)

Created:
7 years, 11 months ago by palfia
Modified:
7 years, 11 months ago
Reviewers:
kisg, Paul Lind, danno, Yang
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Make HCheckPrototypeMaps compatible with parallel recompilation. Port r13454 (2c0dd0ff) Original commit message: HCheckPrototypeMaps currently records the prototype and the holder of the prototype chain (both ends of the chain) and assumes that the chain elements and their maps did not change in during the entirety of Crankshaft. The actual traversal of the prototype chain happens in Lithium at code generation. With parallel compilation, this assumption is not longer correct. BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=13476

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -21 lines) Patch
M src/mips/lithium-codegen-mips.cc View 1 chunk +9 lines, -19 lines 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
palfia
7 years, 11 months ago (2013-01-22 16:03:02 UTC) #1
Yang
7 years, 11 months ago (2013-01-23 14:00:49 UTC) #2
On 2013/01/22 16:03:02, palfia wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698