Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/renderer_host/render_view_host_impl.cc

Issue 12036002: Filter more incoming URLs in the CreateWindow path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/common/view_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/render_view_host_impl.cc
===================================================================
--- content/browser/renderer_host/render_view_host_impl.cc (revision 178378)
+++ content/browser/renderer_host/render_view_host_impl.cc (working copy)
@@ -1094,8 +1094,10 @@
ViewHostMsg_CreateWindow_Params validated_params(params);
ChildProcessSecurityPolicyImpl* policy =
ChildProcessSecurityPolicyImpl::GetInstance();
- // TODO(cevans): also validate opener_url, opener_security_origin.
FilterURL(policy, GetProcess(), false, &validated_params.target_url);
+ FilterURL(policy, GetProcess(), false, &validated_params.opener_url);
+ FilterURL(policy, GetProcess(), true,
+ &validated_params.opener_security_origin);
delegate_->CreateNewWindow(route_id, validated_params,
session_storage_namespace);
« no previous file with comments | « content/browser/renderer_host/render_message_filter.cc ('k') | content/common/view_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698