handle bad python install

handle bad python install


BUG=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=181695

[bcwhite, 2013-01-25 00:22:13]

If you have a bad Cygwin/Python install, it can lead to "sys.executable"
returning nothing and "runhooks" failing with no useful error as it tries to
call "".

This patch just alerts to the core failure condition.

[M-A Ruel, 2013-01-25 01:01:30]

https://codereview.chromium.org/12035089/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/12035089/diff/1/gclient.py#newcode705
gclient.py:705: if not command[0]:
Please put it directly first thing into main() instead of deep inside the code.

[bcwhite, 2013-01-30 16:58:53]

https://codereview.chromium.org/12035089/diff/1/gclient.py
File gclient.py (right):

https://codereview.chromium.org/12035089/diff/1/gclient.py#newcode705
gclient.py:705: if not command[0]:
On 2013/01/25 01:01:30, Marc-Antoine Ruel wrote:
> Please put it directly first thing into main() instead of deep inside the
code.

Done.

[bcwhite, 2013-02-08 13:20:03]

ping?

[M-A Ruel, 2013-02-08 18:17:21]

lgtm, sorry it had fell off my radar.

[commit-bot: I haz the power, 2013-02-08 18:17:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/12035089/3001

[commit-bot: I haz the power, 2013-02-08 18:20:31]

Presubmit check for 12035089-3001 failed and returned exit status 1.

************* Module drover
W0311:528,0: Bad indentation. Found 6 spaces, expected 4
W0311:529,0: Bad indentation. Found 6 spaces, expected 4
Running presubmit commit checks ...
Running pylint on 51 files.
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Fix pylint errors first.

Presubmit checks took 162.2s to calculate.

[bcwhite, 2013-02-11 15:53:44]

> ************* Module drover
> W0311:528,0: Bad indentation. Found 6 spaces, expected 4
> W0311:529,0: Bad indentation. Found 6 spaces, expected 4

Not sure what this means.  My patch is at line 1722 and has nothing indented 6
spaces.  I did find a tab, though, so I'll submit a new patch without it.

[anagy4698, 2013-02-11 15:55:38]

https://chromium.googlesource.com/chromium/tools/depot_tools.git@master,.


2013/2/11 <bcwhite@chromium.org>

>
>  ************* Module drover
>> W0311:528,0: Bad indentation. Found 6 spaces, expected 4
>> W0311:529,0: Bad indentation. Found 6 spaces, expected 4
>>
>
> Not sure what this means.  My patch is at line 1722 and has nothing
> indented 6
> spaces.  I did find a tab, though, so I'll submit a new patch without it.
>
>
https://codereview.chromium.**org/12035089/<https://codereview.chromium.org/1...
>



-- 
anagy4698@gmail.com.

[M-A Ruel, 2013-02-11 15:56:04]

On 2013/02/11 15:53:44, bcwhite wrote:
> > ************* Module drover
> > W0311:528,0: Bad indentation. Found 6 spaces, expected 4
> > W0311:529,0: Bad indentation. Found 6 spaces, expected 4
> 
> Not sure what this means.  My patch is at line 1722 and has nothing indented 6
> spaces.  I did find a tab, though, so I'll submit a new patch without it.

Not your fault, someone broke the presubmit check while changing drover.py. I'm
fixing.

[commit-bot: I haz the power, 2013-02-11 16:11:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bcwhite@chromium.org/12035089/10001

[commit-bot: I haz the power, 2013-02-11 16:13:49]

Change committed as 181695