Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 12035084: Remove CF from all.gyp targets if use_aura is defined. (Closed)

Created:
7 years, 11 months ago by robertshield
Modified:
7 years, 11 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, laforge
Visibility:
Public.

Description

Remove CF from all.gyp targets if use_aura is defined. BUG=171018 TEST=Official aura builds compile. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=178752

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -0 lines) Patch
M build/all.gyp View 3 chunks +28 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robertshield
7 years, 11 months ago (2013-01-24 22:42:02 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm
7 years, 11 months ago (2013-01-24 23:20:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/12035084/1
7 years, 11 months ago (2013-01-24 23:30:52 UTC) #3
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=92740
7 years, 11 months ago (2013-01-25 02:20:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/12035084/1
7 years, 11 months ago (2013-01-25 02:57:32 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-25 04:49:21 UTC) #6
Message was sent while issue was closed.
Change committed as 178752

Powered by Google App Engine
This is Rietveld 408576698