Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 12035038: Added a UMA metric to track slow path scrolling. (Closed)

Created:
7 years, 11 months ago by clholgat
Modified:
7 years, 10 months ago
CC:
chromium-reviews, cc-bugs_chromium.org, jamesr, Sami, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@layer_tree
Visibility:
Public.

Description

Added a UMA metric to track slow path scrolling. Using a boolean UMA histogram to track slow scrolling so we know how frequently it happens compared to fast scrolling gives a more complete idea of what's going on. BUG= #164083 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180051

Patch Set 1 #

Total comments: 2

Patch Set 2 : Moved the UMA_HISTOGRAM_BOOLEAN(false) to just before return ScrollStarted #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M cc/layer_tree_host_impl.cc View 1 5 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
clholgat
7 years, 11 months ago (2013-01-22 22:57:13 UTC) #1
clholgat
On 2013/01/22 22:57:13, Carson wrote: Has anyone had a chance to look at this change?
7 years, 10 months ago (2013-01-29 21:30:04 UTC) #2
aelias_OOO_until_Jul13
https://codereview.chromium.org/12035038/diff/1/cc/layer_tree_host_impl.cc File cc/layer_tree_host_impl.cc (right): https://codereview.chromium.org/12035038/diff/1/cc/layer_tree_host_impl.cc#newcode1182 cc/layer_tree_host_impl.cc:1182: UMA_HISTOGRAM_BOOLEAN("TryScroll.SlowScroll", false); Please put this one right before ScrollStarted ...
7 years, 10 months ago (2013-01-29 22:00:08 UTC) #3
clholgat
https://codereview.chromium.org/12035038/diff/1/cc/layer_tree_host_impl.cc File cc/layer_tree_host_impl.cc (right): https://codereview.chromium.org/12035038/diff/1/cc/layer_tree_host_impl.cc#newcode1182 cc/layer_tree_host_impl.cc:1182: UMA_HISTOGRAM_BOOLEAN("TryScroll.SlowScroll", false); On 2013/01/29 22:00:08, aelias wrote: > Please ...
7 years, 10 months ago (2013-01-31 18:55:50 UTC) #4
aelias_OOO_until_Jul13
lgtm
7 years, 10 months ago (2013-01-31 22:46:12 UTC) #5
aelias_OOO_until_Jul13
[+jamesr, skyostil, rjkroege as FYI]
7 years, 10 months ago (2013-01-31 22:48:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/clholgat@chromium.org/12035038/6001
7 years, 10 months ago (2013-01-31 22:59:48 UTC) #7
commit-bot: I haz the power
7 years, 10 months ago (2013-02-01 03:18:18 UTC) #8
Message was sent while issue was closed.
Change committed as 180051

Powered by Google App Engine
This is Rietveld 408576698